[Scummvm-cvs-logs] CVS: scummvm/backends/x11 x11.cpp,1.13,1.14

Max Horn fingolfin at users.sourceforge.net
Sun Jul 6 12:32:08 CEST 2003


Update of /cvsroot/scummvm/scummvm/backends/x11
In directory sc8-pr-cvs1:/tmp/cvs-serv18832

Modified Files:
	x11.cpp 
Log Message:
const fix; expannded TODO comment a bit

Index: x11.cpp
===================================================================
RCS file: /cvsroot/scummvm/scummvm/backends/x11/x11.cpp,v
retrieving revision 1.13
retrieving revision 1.14
diff -u -d -r1.13 -r1.14
--- x11.cpp	6 Jul 2003 05:51:41 -0000	1.13
+++ x11.cpp	6 Jul 2003 19:31:44 -0000	1.14
@@ -458,7 +458,11 @@
 }
 
 void OSystem_X11::clear_sound_proc() {
-	// FIXME implement...
+	// TODO implement this...
+	// The sound_thread has to be stopped in a nice way. In particular,
+	// using pthread_kill would be a bad idea. Rather, use pthread_cancel,
+	// or maybe a global variable, to achieve this.
+	// This method shouldn't return until the sound thread really has stopped.
 }
 
 
@@ -755,7 +759,7 @@
 	cur_state.h = h;
 	cur_state.hot_x = hotspot_x;
 	cur_state.hot_y = hotspot_y;
-	_ms_buf = (byte *)buf;
+	_ms_buf = buf;
 
 	if (_mouse_state_changed == false) {
 		undraw_mouse();
@@ -778,11 +782,6 @@
 {
 	pthread_t *thread = (pthread_t *) malloc(sizeof(pthread_t));
 	pthread_create(thread, NULL, (void *(*)(void *))proc, param);
-	/* if (pthread_create(thread, NULL, (void *(*)(void *))proc, param))
-		return NULL;
-	else
-		return thread;
-	*/
 }
 
 uint32 OSystem_X11::property(int param, Property *value)





More information about the Scummvm-git-logs mailing list