[Scummvm-cvs-logs] CVS: scummvm/bs2 interpreter.cpp,1.1,1.2

Max Horn fingolfin at users.sourceforge.net
Sun Jul 27 19:40:14 CEST 2003


Update of /cvsroot/scummvm/scummvm/bs2
In directory sc8-pr-cvs1:/tmp/cvs-serv9158

Modified Files:
	interpreter.cpp 
Log Message:
big FIXME

Index: interpreter.cpp
===================================================================
RCS file: /cvsroot/scummvm/scummvm/bs2/interpreter.cpp,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -d -r1.1 -r1.2
--- interpreter.cpp	28 Jul 2003 01:44:37 -0000	1.1
+++ interpreter.cpp	28 Jul 2003 02:39:40 -0000	1.2
@@ -325,6 +325,12 @@
 
 	// Get the start of variables and start of code
 	DEBUG3("Enter interpreter data %x, object %x, offset %d",scriptData,objectData,*offset);
+
+	// FIXME: The following is a fundamental (?) flaw in the code.
+	// Both "variables" and "scriptData" are const pointers. However,
+	// later the code actually writes code into "variables". Both can't
+	// be the case at the same time. Either the const qualifiers have
+	// to be removed, or the writes to *variables are bogus.
 	const char *variables = scriptData + sizeof(int);
 	const char *code = scriptData + *((int *)scriptData) + sizeof(int);
 	uint32 noScripts = *((int32 *)code);





More information about the Scummvm-git-logs mailing list