[Scummvm-cvs-logs] CVS: scummvm/scumm gfx.cpp,2.76,2.77

[Max Horn]

Update of /cvsroot/scummvm/scummvm/scumm
In directory sc8-pr-cvs1:/tmp/cvs-serv10718

Modified Files:
	gfx.cpp 
Log Message:
updated my FIXME comment

Index: gfx.cpp
===================================================================
RCS file: /cvsroot/scummvm/scummvm/scumm/gfx.cpp,v
retrieving revision 2.76
retrieving revision 2.77
diff -u -d -r2.76 -r2.77
--- gfx.cpp	8 May 2003 21:14:20 -0000	2.76
+++ gfx.cpp	9 May 2003 01:17:31 -0000	2.77
@@ -1134,7 +1134,7 @@
 	int x, y, length = 0;
 	int run = 1;
 
-	for (x = 0 ; x < room_width << 3; x++) {
+	for (x = 0 ; x < (room_width << 3); x++) {
 
 		if ((x % 8) == 0) {
 			_egaStripRun[x >> 3] = run;
@@ -1206,9 +1206,14 @@
 
 // FIXME - for now only draw the full height stuff.
 // There are also cases where e.g. height = 48. We ignore those for a single
-// reason: in the intro screen, they overdraw the kids faces with a blue
-// rect. Not sure whether that's one purpose or a bug; but for the sake of
-// making it look "more impressive" I put in this temporary hack.
+// reason: in the intro screen, they overdraw the kids faces with a blue rect.
+// For the sake of making it look "more impressive" I put in this temporary hack.
+// The reason for the whole problem seems to be the _egaStripFOO hack (see also buildStripOffsets)
+// Apparently it currently only works for the room graphics, but not for objects.
+// I think instead of forcing all this into drawBitmap(), maybe we should just
+// provide an alternative drawBitmap implementation for V2 games. That might be
+// much easier than trying to coerce the old graphics data into behaving like the
+// newer formats.
 if (height != 128)
 	return;