[Scummvm-cvs-logs] CVS: scummvm/scumm boxes.cpp,1.25,1.26
Max Horn
max at quendi.de
Sat May 17 16:32:03 CEST 2003
- Previous message: [Scummvm-cvs-logs] CVS: scummvm/scumm boxes.cpp,1.25,1.26
- Next message: [Scummvm-cvs-logs] CVS: scummvm/sky gmmusic.cpp,1.3,1.4 musicbase.cpp,1.3,1.4 text.cpp,1.21,1.22 text.h,1.13,1.14
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
Am Samstag, 17.05.03 um 21:12 Uhr schrieb Jonathan Gray:
> Update of /cvsroot/scummvm/scummvm/scumm
> In directory sc8-pr-cvs1:/tmp/cvs-serv17327
>
> Modified Files:
> boxes.cpp
> Log Message:
> I thought it would be clear from the comments that this was needed for
> the atari st zak demo, which seems to still be the case
I thought it was clear from previous discussions that "fixing an
assert" by commenting it out / putting it into an if is about the worst
way to deal with it. If the check fails, that means our code is wrong,
and just ignoring it and hoping all will be fine is *BAD*.
I am going to change it again, to something which might fix the issue
for MIEGA/ZakDemo. If it doesn't we can work on trying to find another
solution. But just not checking for bounds and hoping thru a miracle
all will work fine in all cases is, IMHO, not a good choice.
Max
- Previous message: [Scummvm-cvs-logs] CVS: scummvm/scumm boxes.cpp,1.25,1.26
- Next message: [Scummvm-cvs-logs] CVS: scummvm/sky gmmusic.cpp,1.3,1.4 musicbase.cpp,1.3,1.4 text.cpp,1.21,1.22 text.h,1.13,1.14
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
More information about the Scummvm-git-logs
mailing list