[Scummvm-cvs-logs] CVS: scummvm/scumm object.cpp,1.106,1.107

[Max Horn]

Update of /cvsroot/scummvm/scummvm/scumm
In directory sc8-pr-cvs1:/tmp/cvs-serv24751

Modified Files:
	object.cpp 
Log Message:
cleanup

Index: object.cpp
===================================================================
RCS file: /cvsroot/scummvm/scummvm/scumm/object.cpp,v
retrieving revision 1.106
retrieving revision 1.107
diff -u -d -r1.106 -r1.107
--- object.cpp	24 May 2003 16:02:07 -0000	1.106
+++ object.cpp	26 May 2003 14:44:03 -0000	1.107
@@ -129,34 +129,11 @@
 	if (object < 1)
 		return -1;
 
-#if 1
 	for (i = (_numLocalObjects-1); i > 0; i--) {
 		if (_objs[i].obj_nr == object)
 			return i;
 	}
 	return -1;
-#else
-	// FIXME: this function searches thru the _inventory. Yet almost all
-	// functions calling it assumg the index will always be into _objs.
-	// For script_v2.cpp this already caused some hard to track buglets.
-	// Maybe it also causes problems in other places. The question is,
-	// under which cirumstances would the _inventory result ever be
-	// useful for us?
-
-	// OF_OWNER_ROOM should be 0xFF for full throttle, else 0xF
-	if (_objectOwnerTable[object] != OF_OWNER_ROOM) {
-		for (i = 0; i < _maxInventoryItems; i++)
-			if (_inventory[i] == object)
-				return i;
-		return -1;
-	} else {
-		for (i = (_numLocalObjects-1); i > 0; i--) {
-			if (_objs[i].obj_nr == object)
-				return i;
-		}
-		return -1;
-	}
-#endif
 }
 
 int Scumm::whereIsObject(int object) {
@@ -977,9 +954,7 @@
 
 	slot = getInventorySlot();
 	_inventory[slot] = obj;
-	createResource(rtInventory, slot, size);
-
-	dst = getResourceAddress(rtInventory, slot);
+	dst = createResource(rtInventory, slot, size);
 	assert(dst);
 	memcpy(dst, ptr, size);
 
@@ -998,7 +973,7 @@
 	if (findWhat & foCheckAlreadyLoaded && getObjectIndex(id) != -1) {
 		if (_features & GF_OLD_BUNDLE) {
 			// I am not sure if this is even needed for old games...
-			// but using RES_SIZE defintily won't work with OLD_BUNDLE, since it
+			// but using RES_SIZE definitely won't work with OLD_BUNDLE, since it
 			// assumes the size is 32 bit but in old games it's 16 bit
 			error("findObjectInRoom foCheckAlreadyLoaded NYI for GF_OLD_BUNDLE (id = %d, room = %d)", id, room);
 		}
@@ -1795,8 +1770,7 @@
 
 	// Allocate slot & memory for floating object
 	slot = findFlObjectSlot();
-	createResource(rtFlObject, slot, flob_size);
-	flob = getResourceAddress(rtFlObject, slot);
+	flob = createResource(rtFlObject, slot, flob_size);
 	assert(flob);
 
 	// Copy object code + object image to floating object