[Scummvm-cvs-logs] CVS: scummvm/scumm bundle.cpp,1.39,1.40 bundle.h,1.16,1.17

Max Horn fingolfin at users.sourceforge.net
Tue May 27 19:09:03 CEST 2003


Update of /cvsroot/scummvm/scummvm/scumm
In directory sc8-pr-cvs1:/tmp/cvs-serv9402

Modified Files:
	bundle.cpp bundle.h 
Log Message:
cleanup

Index: bundle.cpp
===================================================================
RCS file: /cvsroot/scummvm/scummvm/scumm/bundle.cpp,v
retrieving revision 1.39
retrieving revision 1.40
diff -u -d -r1.39 -r1.40
--- bundle.cpp	21 May 2003 18:09:46 -0000	1.39
+++ bundle.cpp	28 May 2003 02:08:30 -0000	1.40
@@ -24,7 +24,7 @@
 #include "bundle.h"
 #include "file.h"
 
-const int16 imcTable[] = {
+static const int16 imcTable[] = {
 	0x0007, 0x0008, 0x0009, 0x000A, 0x000B, 0x000C, 0x000D, 0x000E, 0x0010, 0x0011,
 	0x0013, 0x0015, 0x0017, 0x0019, 0x001C, 0x001F, 0x0022, 0x0025, 0x0029, 0x002D,
 	0x0032, 0x0037, 0x003C, 0x0042, 0x0049, 0x0050, 0x0058, 0x0061, 0x006B, 0x0076,
@@ -36,7 +36,7 @@
 	0x3BB9, 0x41B2, 0x4844, 0x4F7E, 0x5771, 0x602F, 0x69CE, 0x7462, 0x7FFF
 };
 
-const byte imxOtherTable[6][128] = {
+static const byte imxOtherTable[6][128] = {
 	{
 		0xFF, 0x04, 0xFF, 0x04
 	},
@@ -103,7 +103,8 @@
 	_numMusicFiles = 0;
 
 	_lastSong = -1;
-	_initializedImcTables = false;
+
+	initializeImcTables();
 }
 
 Bundle::~Bundle() {
@@ -114,9 +115,6 @@
 }
 
 void Bundle::initializeImcTables() {
-	if (_initializedImcTables == true)
-		return;
-
 	int32 destTablePos = 0;
 	int32 imcTable1Pos = 0;
 	do {
@@ -158,16 +156,12 @@
 			destTablePos += 64;
 		} while (++imcTable1Pos <= 88);
 	}
-
-	_initializedImcTables = true;
 }
 
 bool Bundle::openVoiceFile(const char *filename, const char *directory) {
 	int32 tag, offset;
 
-	initializeImcTables();
-
-	if (_voiceFile.isOpen() == true)
+	if (_voiceFile.isOpen())
 		return true;
 
 	if (_voiceFile.open(filename, directory) == false) {
@@ -204,12 +198,17 @@
 	return true;
 }
 
+void Bundle::closeVoiceFile() {
+	if (_voiceFile.isOpen()) {
+		_voiceFile.close();
+		free(_bundleVoiceTable);
+	}
+}
+
 bool Bundle::openMusicFile(const char *filename, const char *directory) {
 	int32 tag, offset;
 
-	initializeImcTables();
-
-	if (_musicFile.isOpen() == true)
+	if (_musicFile.isOpen())
 		return true;
 
 	if (_musicFile.open(filename, directory) == false) {
@@ -245,6 +244,14 @@
 
 	return true;
 }
+
+void Bundle::closeMusicFile() {
+	if (_musicFile.isOpen()) {
+		_musicFile.close();
+		free(_bundleMusicTable);
+	}
+}
+
 
 int32 Bundle::decompressVoiceSampleByIndex(int32 index, byte **comp_final) {
 	int32 i, tag, num, final_size, output_size;

Index: bundle.h
===================================================================
RCS file: /cvsroot/scummvm/scummvm/scumm/bundle.h,v
retrieving revision 1.16
retrieving revision 1.17
diff -u -d -r1.16 -r1.17
--- bundle.h	21 May 2003 18:09:46 -0000	1.16
+++ bundle.h	28 May 2003 02:08:31 -0000	1.17
@@ -48,7 +48,6 @@
 	int32 _numMusicFiles;
 	int32 _lastSong;
 
-	bool _initializedImcTables;
 	byte _destImcTable[93];
 	uint32 _destImcTable2[5697];
 
@@ -65,8 +64,8 @@
 	void initializeImcTables();
 	bool openVoiceFile(const char *filename, const char *directory);
 	bool openMusicFile(const char *filename, const char *directory);
-	void closeVoiceFile() { _voiceFile.close(); }
-	void closeMusicFile() { _musicFile.close(); }
+	void closeVoiceFile();
+	void closeMusicFile();
 	int32 decompressVoiceSampleByName(const char *name, byte **comp_final);
 	int32 decompressVoiceSampleByIndex(int32 index, byte **comp_final);
 	int32 decompressMusicSampleByName(const char *name, int32 number, byte *comp_final);





More information about the Scummvm-git-logs mailing list