[Scummvm-cvs-logs] CVS: scummvm/scumm saveload.cpp,1.81,1.82
Max Horn
fingolfin at users.sourceforge.net
Sat May 31 05:21:06 CEST 2003
- Previous message: [Scummvm-cvs-logs] CVS: scummvm/scumm object.cpp,1.112,1.113 resource.cpp,1.94,1.95 script.cpp,1.105,1.106 scumm.h,1.230,1.231 scummvm.cpp,2.193,2.194
- Next message: [Scummvm-cvs-logs] CVS: scummvm/scumm object.cpp,1.113,1.114 script_v2.cpp,2.129,2.130 script_v5.cpp,1.106,1.107 scumm.h,1.231,1.232 string.cpp,1.126,1.127
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
Update of /cvsroot/scummvm/scummvm/scumm
In directory sc8-pr-cvs1:/tmp/cvs-serv28630
Modified Files:
saveload.cpp
Log Message:
FIXME comment added
Index: saveload.cpp
===================================================================
RCS file: /cvsroot/scummvm/scummvm/scumm/saveload.cpp,v
retrieving revision 1.81
retrieving revision 1.82
diff -u -d -r1.81 -r1.82
--- saveload.cpp 29 May 2003 11:48:44 -0000 1.81
+++ saveload.cpp 31 May 2003 12:16:49 -0000 1.82
@@ -566,13 +566,17 @@
s->saveLoadArrayOf(_verbs, _numVerbs, sizeof(_verbs[0]), verbEntries);
s->saveLoadArrayOf(vm.nest, 16, sizeof(vm.nest[0]), nestedScriptEntries);
s->saveLoadArrayOf(_sentence, 6, sizeof(_sentence[0]), sentenceTabEntries);
- /* XXX: next time save game format changes, Fingolfin wants to revise StringTab - contact him */
s->saveLoadArrayOf(_string, 6, sizeof(_string[0]), stringTabEntries);
s->saveLoadArrayOf(_colorCycle, 16, sizeof(_colorCycle[0]), colorCycleEntries);
if (savegameVersion >= VER_V13)
s->saveLoadArrayOf(_scaleSlots, 20, sizeof(_scaleSlots[0]), scaleSlotsEntries);
+ // Save all resource. Fingolfin doesn't like this part of the save/load code a bit.
+ // It is very fragile: e.g. if we change the num limit for one resource type, this
+ // code will break down. Worse, there is no way such a problem could easily be detected.
+ // We should at least store for each save resource it's type and ID. Then at least
+ // we can perform some integrety checks when loading.
for (i = rtFirst; i <= rtLast; i++)
if (res.mode[i] == 0)
for (j = 1; j < res.num[i]; j++)
- Previous message: [Scummvm-cvs-logs] CVS: scummvm/scumm object.cpp,1.112,1.113 resource.cpp,1.94,1.95 script.cpp,1.105,1.106 scumm.h,1.230,1.231 scummvm.cpp,2.193,2.194
- Next message: [Scummvm-cvs-logs] CVS: scummvm/scumm object.cpp,1.113,1.114 script_v2.cpp,2.129,2.130 script_v5.cpp,1.106,1.107 scumm.h,1.231,1.232 string.cpp,1.126,1.127
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
More information about the Scummvm-git-logs
mailing list