[Scummvm-cvs-logs] CVS: scummvm/base gameDetector.cpp,1.35,1.36 gameDetector.h,1.15,1.16 main.cpp,1.16,1.17

Max Horn fingolfin at users.sourceforge.net
Fri Oct 17 10:06:09 CEST 2003


Update of /cvsroot/scummvm/scummvm/base
In directory sc8-pr-cvs1:/tmp/cvs-serv17384/base

Modified Files:
	gameDetector.cpp gameDetector.h main.cpp 
Log Message:
cleanup

Index: gameDetector.cpp
===================================================================
RCS file: /cvsroot/scummvm/scummvm/base/gameDetector.cpp,v
retrieving revision 1.35
retrieving revision 1.36
diff -u -d -r1.35 -r1.36
--- gameDetector.cpp	17 Oct 2003 16:04:46 -0000	1.35
+++ gameDetector.cpp	17 Oct 2003 17:05:19 -0000	1.36
@@ -48,17 +48,6 @@
                             current_option = NULL
 
 // DONT FIXME: DO NOT ORDER ALPHABETICALY, THIS IS ORDERED BY IMPORTANCE/CATEGORY! :)
-// FIXME: Reconsider and reevaluate our command line options. I propose some changes:
-// * add long alternatives for (almost?) all options. There should be some generic way
-//   to specify this, in order to avoid code duplication and to simplify the code
-// * some more obscure options which currently have a single-letter options assigned
-//   really don't need it. E.g. the "-t<NUM>" option probably is rarely used, and anybody
-//   who needs it should still be happy with "--tempo=NUM"
-//   This will make room in the ranks of single-letter options for other more useful options
-//   (for example, "-t" could stand for "List (T)argets")
-// * -y, -t, -c, -j all are candidates for this, IMHO: their settings are rather obscure,
-//   and anybody who needs them always should put them into the config file anyway
-//
 #ifdef __PALM_OS__
 static const char USAGE_STRING[] = "NoUsageString"; // save more data segment space
 #else
@@ -200,8 +189,6 @@
 
 	_dumpScripts = false;
 	_midi_driver = MD_AUTO;
-
-	_saveconfig = false;
 
 	_game.features = 0;
 	_plugin = 0;

Index: gameDetector.h
===================================================================
RCS file: /cvsroot/scummvm/scummvm/base/gameDetector.h,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -d -r1.15 -r1.16
--- gameDetector.h	17 Oct 2003 16:04:46 -0000	1.15
+++ gameDetector.h	17 Oct 2003 17:05:19 -0000	1.16
@@ -70,7 +70,6 @@
 	const Plugin *_plugin;
 	
 	bool _dumpScripts;
-	bool _saveconfig;
 
 	int _midi_driver;
 

Index: main.cpp
===================================================================
RCS file: /cvsroot/scummvm/scummvm/base/main.cpp,v
retrieving revision 1.16
retrieving revision 1.17
diff -u -d -r1.16 -r1.17
--- main.cpp	12 Oct 2003 18:46:50 -0000	1.16
+++ main.cpp	17 Oct 2003 17:05:19 -0000	1.17
@@ -241,7 +241,6 @@
 
 	// Parse the command line information
 	GameDetector detector;
-	detector._saveconfig = false;
 	detector.parseCommandLine(argc, argv);	
 
 	// Create the system object





More information about the Scummvm-git-logs mailing list