[Scummvm-cvs-logs] CVS: scummvm/scumm imuse.cpp,2.92,2.93

Jamieson Christian jamieson630 at users.sourceforge.net
Mon Sep 15 14:36:05 CEST 2003


Update of /cvsroot/scummvm/scummvm/scumm
In directory sc8-pr-cvs1:/tmp/cvs-serv7801/scummvm/scumm

Modified Files:
	imuse.cpp 
Log Message:
Feature Request [806641] Increase MIDI
performance by omitting redundancies

Removed the use of the _bank member for iMuse Parts.
The member is still being saved/loaded, and a
warning will display if a non-zero _bank value is
set. If it turns out some musical passage is actually
using the _bank, we'll need to reinstate it.
Otherwise, after sufficient testing we can obsolete
it in the savegames.

Index: imuse.cpp
===================================================================
RCS file: /cvsroot/scummvm/scummvm/scumm/imuse.cpp,v
retrieving revision 2.92
retrieving revision 2.93
diff -u -d -r2.92 -r2.93
--- imuse.cpp	14 Sep 2003 20:34:48 -0000	2.92
+++ imuse.cpp	15 Sep 2003 21:35:30 -0000	2.93
@@ -1534,7 +1534,7 @@
 		if (!mc)
 			return;
 		mc->volume(_vol_eff);
-		mc->programChange(_bank);
+//		mc->programChange(_bank);
 		mc->noteOn(note, velocity);
 	}
 }
@@ -1658,6 +1658,8 @@
 
 void Part::set_instrument(uint b) {
 	_bank = (byte)(b >> 8);
+	if (_bank)
+		warning ("Non-zero instrument bank selection. Please report this");
 	_instrument.program((byte) b, _player->isMT32());
 	if (clearToTransmit())
 		_instrument.send(_mc);





More information about the Scummvm-git-logs mailing list