[Scummvm-cvs-logs] CVS: scummvm/sound mididrv.h,1.34,1.35
Jamieson Christian
jamieson630 at users.sourceforge.net
Mon Apr 26 13:36:07 CEST 2004
Update of /cvsroot/scummvm/scummvm/sound
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv6857/scummvm/sound
Modified Files:
mididrv.h
Log Message:
MIDI control change 18 is no longer transmitted.
It is not a valid MIDI control change message.
It is used internally in the SCUMM MIDI tracks
to indicate part priority.
The only MidiDriver that needs it is Adlib.
It should be noted that the priority values are
out of bounds for a regular MIDI message anyway.
Valid control change values are 0-127, but the
priority value ranges from 0-255.
This fixes a crash with a certain software MT-32
emulator running under Linux. Thanks to olki for
bringing up this issue.
Index: mididrv.h
===================================================================
RCS file: /cvsroot/scummvm/scummvm/sound/mididrv.h,v
retrieving revision 1.34
retrieving revision 1.35
diff -u -d -r1.34 -r1.35
--- mididrv.h 6 Feb 2004 08:35:24 -0000 1.34
+++ mididrv.h 26 Apr 2004 20:34:59 -0000 1.35
@@ -154,7 +154,7 @@
virtual void panPosition (byte value) { controlChange (10, value); }
virtual void pitchBendFactor (byte value) = 0;
virtual void detune (byte value) { controlChange (17, value); }
- virtual void priority (byte value) { controlChange (18, value); }
+ virtual void priority (byte value) { }
virtual void sustain (bool value) { controlChange (64, value ? 1 : 0); }
virtual void effectLevel (byte value) { controlChange (91, value); }
virtual void chorusLevel (byte value) { controlChange (93, value); }
More information about the Scummvm-git-logs
mailing list