[Scummvm-cvs-logs] CVS: scummvm/common str.cpp,1.28,1.29

Max Horn fingolfin at users.sourceforge.net
Fri Feb 13 17:19:03 CET 2004


Update of /cvsroot/scummvm/scummvm/common
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv24038

Modified Files:
	str.cpp 
Log Message:
Fix for bug #896506 (GUI: Invalid read)

Index: str.cpp
===================================================================
RCS file: /cvsroot/scummvm/scummvm/common/str.cpp,v
retrieving revision 1.28
retrieving revision 1.29
diff -u -d -r1.28 -r1.29
--- str.cpp	6 Jan 2004 12:45:28 -0000	1.28
+++ str.cpp	14 Feb 2004 01:12:35 -0000	1.29
@@ -172,8 +172,10 @@
 }
 
 void String::insertChar(char c, int p) {
+	// FIXME: This should be an 'assert', not an 'if' !
 	if (p >= 0 && p <= _len) {
-		ensureCapacity(++_len, true);
+		ensureCapacity(_len + 1, true);
+		_len++;
 		for (int i = _len; i > p; i--) {
 			_str[i] = _str[i-1];
 		}





More information about the Scummvm-git-logs mailing list