[Scummvm-cvs-logs] CVS: scummvm/scumm string.cpp,1.178,1.179
Max Horn
fingolfin at users.sourceforge.net
Tue Jan 6 04:03:01 CET 2004
Update of /cvsroot/scummvm/scummvm/scumm
In directory sc8-pr-cvs1:/tmp/cvs-serv6724
Modified Files:
string.cpp
Log Message:
This one (_blitAlso) is very odd, I can't quite figure out where it is needed. Please report any regressions to me
Index: string.cpp
===================================================================
RCS file: /cvsroot/scummvm/scummvm/scumm/string.cpp,v
retrieving revision 1.178
retrieving revision 1.179
diff -u -d -r1.178 -r1.179
--- string.cpp 5 Jan 2004 16:19:14 -0000 1.178
+++ string.cpp 6 Jan 2004 12:02:18 -0000 1.179
@@ -446,8 +446,23 @@
}
} else {
if (a == 1 && _version >= 6) {
- if (_string[a].no_talk_anim == 0)
- _charset->_blitAlso = true;
+ // FIXME: Fingolfin would like to know what this code is good
+ // for, exactly. It seems it was added a *looong* time ago, in
+ // the old CVS module. See revisions 1.5 and 1.37 of the
+ // original string.cpp file.
+ // In particular, what kind of regressions might occur when it
+ // is removed, I wonder... so I am disabling it for now.
+ // Please report any regressions you observe to Fingolfin :-)
+ //
+ // Note #1: _blitAlso causes things to be "imprinted" on the
+ // room background. Maybe it is used in some room to write
+ // some text 'permanently' ?
+ // Note #2: If triggered "accidentaly", this code could also
+ // cause code to be left printed when it shouldn't...
+ if (_string[a].no_talk_anim == false) {
+warning("Would have set _charset->_blitAlso = true (wanted to print '%c' = %d\n", c, c);
+// _charset->_blitAlso = true;
+ }
}
if (c >= 0x80 && _CJKMode)
c += buf[i++] * 256;
More information about the Scummvm-git-logs
mailing list