[Scummvm-cvs-logs] CVS: residual timer.cpp,1.8,1.9

Max Horn fingolfin at users.sourceforge.net
Sat Mar 27 10:42:02 CET 2004


Update of /cvsroot/scummvm/residual
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv15783

Modified Files:
	timer.cpp 
Log Message:
this comment doesn't apply for SDL

Index: timer.cpp
===================================================================
RCS file: /cvsroot/scummvm/residual/timer.cpp,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -d -r1.8 -r1.9
--- timer.cpp	27 Mar 2004 15:41:32 -0000	1.8
+++ timer.cpp	27 Mar 2004 18:30:04 -0000	1.9
@@ -56,15 +56,6 @@
 		}
 	}
 
-
-	// FIXME: There is still a potential race condition here, depending on how
-	// the system backend implements set_timer: If timers are done using
-	// threads, and if set_timer does *not* gurantee that after it terminates
-	// that timer thread is not run anymore, we are fine. However, if the timer
-	// is still running in parallel to this destructor, then it might be that
-	// it is still waiting for the _mutex. So, again depending on the backend,
-	// we might end up unlocking the mutex then immediately deleting it, while
-	// the timer thread is about to lock it.
 	delete_mutex(_mutex);
 }
 





More information about the Scummvm-git-logs mailing list