[Scummvm-cvs-logs] CVS: tools extract-common.c,1.6,1.7

Max Horn fingolfin at users.sourceforge.net
Sun Mar 28 08:49:06 CEST 2004


Update of /cvsroot/scummvm/tools
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv17224

Modified Files:
	extract-common.c 
Log Message:
added a FIXME comment

Index: extract-common.c
===================================================================
RCS file: /cvsroot/scummvm/tools/extract-common.c,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -d -r1.6 -r1.7
--- extract-common.c	22 Feb 2004 12:54:27 -0000	1.6
+++ extract-common.c	28 Mar 2004 16:37:15 -0000	1.7
@@ -38,6 +38,14 @@
 	bool silent;
 } oggencparams;
 
+/* FIXME: This is an evil way to pass on the params to FLAC.
+ It makes it near impossible to reliably pass default params to the
+ encoder, which is why the ScummVM README has to tell the user to
+ use this command:
+   extract --best -b 1152 monster.sou
+ If those are the best default options, then they should be *default*
+ and the user shouldn't have to specify them.
+*/
 typedef struct {
 	char * const* argv;
 	int numArgs;





More information about the Scummvm-git-logs mailing list