[Scummvm-cvs-logs] CVS: scummvm/scumm script_v90he.cpp,2.8,2.9

Travis Howell kirben at users.sourceforge.net
Mon Sep 6 19:54:01 CEST 2004


Update of /cvsroot/scummvm/scummvm/scumm
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv15225/scumm

Modified Files:
	script_v90he.cpp 
Log Message:

Switch to cases, to catch any missing cases.


Index: script_v90he.cpp
===================================================================
RCS file: /cvsroot/scummvm/scummvm/scumm/script_v90he.cpp,v
retrieving revision 2.8
retrieving revision 2.9
diff -u -d -r2.8 -r2.9
--- script_v90he.cpp	6 Sep 2004 09:27:22 -0000	2.8
+++ script_v90he.cpp	7 Sep 2004 02:53:22 -0000	2.9
@@ -505,17 +505,22 @@
 
 void ScummEngine_v90he::o90_unknown26() {
 	// Incomplete
-	int value = fetchScriptByte();
-	value -= 34;
+	int subOp = fetchScriptByte();
+	subOp -= 34;
 
-	if (value == 10) {
-		pop();
-		pop();
-	} else if (value == 23) {
-		pop();
+	switch (subOp) {
+		case 10:
+			pop();
+			pop();
+			break;
+		case 23:
+			pop();
+			break;
+		case 124:
+			break;
+		default:
+			error("o90_unknown26: Unknown case %d", subOp);
 	}
-
-	debug(1,"o90_unknown26 stub (%d)", value);
 }
 
 void ScummEngine_v90he::o90_unknown27() {
@@ -540,14 +545,16 @@
 
 void ScummEngine_v90he::o90_unknown28() {
 	// Incomplete
-	int value = fetchScriptByte();
-	value -= 37;
+	int subOp = fetchScriptByte();
+	subOp -= 37;
 
-	if (value == 20) {
-		pop();
+	switch (subOp) {
+		case 20:
+			pop();
+			break;
+		default:
+			error("o90_unknown28: Unknown case %d", subOp);
 	}
-
-	debug(1,"o90_unknown28 stub (%d)", value);
 }
 
 } // End of namespace Scumm





More information about the Scummvm-git-logs mailing list