[Scummvm-cvs-logs] CVS: scummvm/scumm intern.h,2.270,2.271 script_v6.cpp,1.407,1.408 scumm.cpp,1.230,1.231 scumm.h,1.499,1.500 verbs.cpp,1.111,1.112

[Max Horn]

Update of /cvsroot/scummvm/scummvm/scumm
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv27268

Modified Files:
	intern.h script_v6.cpp scumm.cpp scumm.h verbs.cpp 
Log Message:
some more pointless cleanup / moving around of stuff :-)

Index: intern.h
===================================================================
RCS file: /cvsroot/scummvm/scummvm/scumm/intern.h,v
retrieving revision 2.270
retrieving revision 2.271
diff -u -d -r2.270 -r2.271
--- intern.h	23 Sep 2004 09:11:51 -0000	2.270
+++ intern.h	26 Sep 2004 07:30:24 -0000	2.271
@@ -209,6 +209,8 @@
 public:
 	ScummEngine_v2(GameDetector *detector, OSystem *syst, const ScummGameSettings &gs, uint8 md5sum[16]) : ScummEngine_v3(detector, syst, gs, md5sum) {}
 
+	virtual void scummInit();
+
 protected:
 	virtual void setupOpcodes();
 	virtual void executeOpcode(byte i);
@@ -232,6 +234,8 @@
 	void resetSentence();
 	void setUserState(byte state);
 
+	void initV2MouseOver();
+
 	/* Version 2 script opcodes */
 	void o2_actorFromPos();
 	void o2_actorOps();
@@ -567,6 +571,8 @@
 public:
 	ScummEngine_v60he(GameDetector *detector, OSystem *syst, const ScummGameSettings &gs, uint8 md5sum[16]) : ScummEngine_v6(detector, syst, gs, md5sum) {}
 
+	virtual void scummInit();
+
 protected:
 	virtual void setupOpcodes();
 	virtual void executeOpcode(byte i);

Index: script_v6.cpp
===================================================================
RCS file: /cvsroot/scummvm/scummvm/scumm/script_v6.cpp,v
retrieving revision 1.407
retrieving revision 1.408
diff -u -d -r1.407 -r1.408
--- script_v6.cpp	23 Sep 2004 19:49:59 -0000	1.407
+++ script_v6.cpp	26 Sep 2004 07:30:25 -0000	1.408
@@ -1478,7 +1478,7 @@
 void ScummEngine_v6::o6_getVerbFromXY() {
 	int y = pop();
 	int x = pop();
-	int over = checkMouseOver(x, y);
+	int over = findVerbAtPos(x, y);
 	if (over)
 		over = _verbs[over].verbid;
 	push(over);

Index: scumm.cpp
===================================================================
RCS file: /cvsroot/scummvm/scummvm/scumm/scumm.cpp,v
retrieving revision 1.230
retrieving revision 1.231
diff -u -d -r1.230 -r1.231
--- scumm.cpp	26 Sep 2004 06:50:08 -0000	1.230
+++ scumm.cpp	26 Sep 2004 07:30:26 -0000	1.231
@@ -1152,15 +1152,6 @@
 			setupEGAPalette();
 	}
 
-	if (_version <= 2) {
-		initV2MouseOver();
-
-		// Seems in V2 there was only a single room effect (iris),
-		// so we set that here.
-		_switchRoomEffect2 = 1;
-		_switchRoomEffect = 5;
-	}
-	
 	if (_version > 3 && _version < 8)
 		loadCharset(1);
 	
@@ -1286,14 +1277,18 @@
 	for (i = 0; i < 512; i++)
 		_keyDownMap[i] = false;
 
-	if (_heversion >= 70) {
-		if (_wizPolygons)
-			free (_wizPolygons);
+	_lastSaveTime = _system->get_msecs();
+}
 
-		_wizPolygons = (WizPolygon *)calloc(_wizNumPolygons, sizeof(WizPolygon));
-	}
+void ScummEngine_v2::scummInit() {
+	ScummEngine::scummInit();
 
-	_lastSaveTime = _system->get_msecs();
+	initV2MouseOver();
+
+	// Seems in V2 there was only a single room effect (iris),
+	// so we set that here.
+	_switchRoomEffect2 = 1;
+	_switchRoomEffect = 5;
 }
 
 void ScummEngine_v6::scummInit() {
@@ -1312,6 +1307,16 @@
 		setCursorHotspot(16, 16);
 }
 
+void ScummEngine_v60he::scummInit() {
+	ScummEngine::scummInit();
+
+	if (_heversion >= 70) {
+		free(_wizPolygons);
+
+		_wizPolygons = (WizPolygon *)calloc(_wizNumPolygons, sizeof(WizPolygon));
+	}
+}
+
 void ScummEngine::setupMusic(int midi) {
 	_midiDriver = GameDetector::detectMusicDriver(midi);
 	_native_mt32 = ConfMan.getBool("native_mt32");
@@ -1662,7 +1667,7 @@
 		}
 
 		if (_cursor.state > 0)
-			verbMouseOver(checkMouseOver(_mouse.x, _mouse.y));
+			verbMouseOver(findVerbAtPos(_mouse.x, _mouse.y));
 
 		if (_version <= 2) {
 			if (oldEgo != VAR(VAR_EGO)) {

Index: scumm.h
===================================================================
RCS file: /cvsroot/scummvm/scummvm/scumm/scumm.h,v
retrieving revision 1.499
retrieving revision 1.500
diff -u -d -r1.499 -r1.500
--- scumm.h	25 Sep 2004 23:14:09 -0000	1.499
+++ scumm.h	26 Sep 2004 07:30:28 -0000	1.500
@@ -801,7 +801,7 @@
 	void redrawVerbs();
 	void checkExecVerbs();
 	void verbMouseOver(int verb);
-	int checkMouseOver(int x, int y) const;
+	int findVerbAtPos(int x, int y) const;
 	void drawVerb(int verb, int mode);
 	void runInputScript(int a, int cmd, int mode);
 	void restoreVerbBG(int verb);
@@ -815,7 +815,6 @@
 	V2MouseoverBox v2_mouseover_boxes[7];
 	int8 v2_mouseover_box;
 
-	void initV2MouseOver();
 	void checkV2MouseOver(Common::Point pos);
 	void checkV2Inventory(int x, int y);
 	void redrawV2Inventory();

Index: verbs.cpp
===================================================================
RCS file: /cvsroot/scummvm/scummvm/scumm/verbs.cpp,v
retrieving revision 1.111
retrieving revision 1.112
diff -u -d -r1.111 -r1.112
--- verbs.cpp	24 Sep 2004 21:49:52 -0000	1.111
+++ verbs.cpp	26 Sep 2004 07:30:29 -0000	1.112
@@ -22,6 +22,7 @@
 
 #include "stdafx.h"
 #include "scumm/charset.h"
+#include "scumm/intern.h"
 #include "scumm/object.h"
 #include "scumm/resource.h"
 #include "scumm/scumm.h"
@@ -35,7 +36,7 @@
 	kSentenceLine = 6
 };
 
-void ScummEngine::initV2MouseOver() {
+void ScummEngine_v2::initV2MouseOver() {
 	int i;
 	int arrow_color, color, hi_color;
 
@@ -266,7 +267,7 @@
 
 	int i, verb = 0;
 	if (_cursor.state > 0)
-		verb = checkMouseOver(_mouse.x, _mouse.y);
+		verb = findVerbAtPos(_mouse.x, _mouse.y);
 
 	for (i = _numVerbs-1; i >= 0; i--) {
 		if (i == verb && _verbs[verb].hicolor)
@@ -308,7 +309,7 @@
 			// Click into V2 inventory
 			checkV2Inventory(_mouse.x, _mouse.y);
 		} else {
-			over = checkMouseOver(_mouse.x, _mouse.y);
+			over = findVerbAtPos(_mouse.x, _mouse.y);
 			if (over != 0) {
 				// Verb was clicked
 				runInputScript(1, _verbs[over].verbid, code);
@@ -342,7 +343,7 @@
 	}
 }
 
-int ScummEngine::checkMouseOver(int x, int y) const {
+int ScummEngine::findVerbAtPos(int x, int y) const {
 	if (!_numVerbs)
 		return 0;