[Scummvm-cvs-logs] CVS: scummvm/scumm palette.cpp,2.37,2.38
kirben
kirben at users.sourceforge.net
Tue Apr 19 00:43:15 CEST 2005
Update of /cvsroot/scummvm/scummvm/scumm
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv630/scumm
Modified Files:
palette.cpp
Log Message:
Remove FIXME comment, the current code is correct.
The 6/6/6 style palettes are just SCUMM 5/6 specific.
Index: palette.cpp
===================================================================
RCS file: /cvsroot/scummvm/scummvm/scumm/palette.cpp,v
retrieving revision 2.37
retrieving revision 2.38
diff -u -d -r2.37 -r2.38
--- palette.cpp 19 Apr 2005 07:28:43 -0000 2.37
+++ palette.cpp 19 Apr 2005 07:42:51 -0000 2.38
@@ -231,13 +231,7 @@
g = *ptr++;
b = *ptr++;
- // This comparison might look weird, but it's what the disassembly (DOTT) says!
- // FIXME: Fingolfin still thinks it looks weird: the value 252 = 4*63 clearly comes from
- // the days 6/6/6 palettes were used, OK. But it breaks MonkeyVGA, so I had to add a
- // check for that. And somebody before me added a check for V7 games, turning this
- // off there, too... I wonder if it hurts other games, too? What exactly is broken
- // if we remove this patch?
- // Since it also causes problems in Zak256, I am turning it off for all V4 games and older.
+ // Only SCUMM 5/6 games use 6/6/6 style palettes
if (_version >= 5 && _version <= 6) {
if ((_heversion <= 72 && i < 15) || i == 15 || r < 252 || g < 252 || b < 252) {
*dest++ = r;
More information about the Scummvm-git-logs
mailing list