[Scummvm-cvs-logs] CVS: scummvm/scumm input.cpp,2.46,2.47 saveload.cpp,1.256,1.257 script_v72he.cpp,2.314,2.315 vars.cpp,1.153,1.154

[kirben]

Update of /cvsroot/scummvm/scummvm/scumm
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv18930/scumm

Modified Files:
	input.cpp saveload.cpp script_v72he.cpp vars.cpp 
Log Message:

SCUMM 6 games use VAR_VOICE_MODE too, based on Sam & Max win32 disasm.
Minor cleanup.


Index: input.cpp
===================================================================
RCS file: /cvsroot/scummvm/scummvm/scumm/input.cpp,v
retrieving revision 2.46
retrieving revision 2.47
diff -u -d -r2.46 -r2.47
--- input.cpp	10 Nov 2005 23:09:19 -0000	2.46
+++ input.cpp	15 Nov 2005 22:50:14 -0000	2.47
@@ -345,7 +345,7 @@
 			break;
 		}
 
-		if (_version >= 7)
+		if (VAR_VOICE_MODE != 0xFF)
 			VAR(VAR_VOICE_MODE) = _voiceMode;
 
 		GUI::TimedMessageDialog dialog(buf, 1500);

Index: saveload.cpp
===================================================================
RCS file: /cvsroot/scummvm/scummvm/scumm/saveload.cpp,v
retrieving revision 1.256
retrieving revision 1.257
diff -u -d -r1.256 -r1.257
--- saveload.cpp	7 Nov 2005 22:57:31 -0000	1.256
+++ saveload.cpp	15 Nov 2005 22:50:14 -0000	1.257
@@ -401,7 +401,7 @@
 		VAR(VAR_ROOM_FLAG) = 1;
 
 	// Sync with current config setting
-	if (_version >= 7)
+	if (VAR_VOICE_MODE != 0xFF)
 		VAR(VAR_VOICE_MODE) = ConfMan.getBool("subtitles");
 
 	CHECK_HEAP

Index: script_v72he.cpp
===================================================================
RCS file: /cvsroot/scummvm/scummvm/scumm/script_v72he.cpp,v
retrieving revision 2.314
retrieving revision 2.315
diff -u -d -r2.314 -r2.315
--- script_v72he.cpp	6 Nov 2005 11:33:58 -0000	2.314
+++ script_v72he.cpp	15 Nov 2005 22:50:14 -0000	2.315
@@ -2218,6 +2218,7 @@
 		value = pop();
 		copyScriptString(option, sizeof(option));
 		ConfMan.set((char *)option, value);
+		debug(0, "o72_writeINI: Option %s Value %d", option, value);
 		break;
 	case 77: // HE 100
 	case 7: // string
@@ -2237,6 +2238,7 @@
 			return;
 
 		ConfMan.set((char *)option, (char *)string);
+		debug(0, "o72_writeINI: Option %s String %s", option);
 		break;
 	default:
 		error("o72_writeINI: default type %d", type);

Index: vars.cpp
===================================================================
RCS file: /cvsroot/scummvm/scummvm/scumm/vars.cpp,v
retrieving revision 1.153
retrieving revision 1.154
diff -u -d -r1.153 -r1.154
--- vars.cpp	10 Nov 2005 23:09:20 -0000	1.153
+++ vars.cpp	15 Nov 2005 22:50:14 -0000	1.154
@@ -176,27 +176,22 @@
 	// Many vars are the same as in V5 & V6 games, so just call the inherited method first
 	ScummEngine::setupScummVars();
 
-	if (_heversion == 0) {
-		VAR_V6_SOUNDMODE = 9;
-	}
-
 	VAR_ROOM_WIDTH = 41;
 	VAR_ROOM_HEIGHT = 54;
 
-	if (_heversion >= 60 && _heversion <= 61) {
+	if (_heversion >= 70) {
+		VAR_SUBTITLES = 60;
+	} else if (_heversion >= 60) {
 		VAR_NOSUBTITLES = 60;
 	} else {
-		VAR_SUBTITLES = 60;
+		VAR_VOICE_MODE = 60; // 0 is voice, 1 is voice+text, 2 is text only
+		VAR_SAVELOAD_SCRIPT = 61;
+		VAR_SAVELOAD_SCRIPT2 = 62;
 	}
 
 	VAR_LEFTBTN_HOLD = 74;
 	VAR_RIGHTBTN_HOLD = 75;
 
-	if (_heversion == 0) {
-		VAR_SAVELOAD_SCRIPT = 61;
-		VAR_SAVELOAD_SCRIPT2 = 62;
-	}
-
 	VAR_V6_EMSSPACE = 76;
 	VAR_RANDOM_NR = 118;
 
@@ -207,7 +202,10 @@
 	VAR_TIMEDATE_MINUTE = 126;
 
 	// Sam & Max specific
-	VAR_CHARSET_MASK = 123;
+	if (_gameId == GID_SAMNMAX) {
+		VAR_V6_SOUNDMODE = 9;
+		VAR_CHARSET_MASK = 123;
+	}
 }
 
 #ifndef DISABLE_HE
@@ -299,8 +297,8 @@
 		VAR_NUM_SOUND_CHANNELS = 56;
 	}
 	if (_heversion >= 80)
-		VAR_PLATFORM = 78;  // 1 is PC, 2 is Macintosh
- 		VAR_WINDOWS_VERSION = 79; // 31 is Windows 3.1, 40 is Windows 95+
+		VAR_PLATFORM = 78;  		// 1 is PC, 2 is Macintosh
+ 		VAR_WINDOWS_VERSION = 79; 	// 31 is Windows 3.1, 40 is Windows 95+
 		VAR_CURRENT_CHARSET = 80;
 		VAR_KEY_STATE = 86;
 		VAR_NUM_SOUND_CHANNELS = 88;
@@ -417,7 +415,9 @@
 	VAR_FADE_DELAY = 117;
 
 	// Full Throttle specific
-	VAR_CHARSET_MASK = 119;
+	if (_gameId == GID_FT) {
+		VAR_CHARSET_MASK = 119;
+	}
 
 	VAR_VIDEONAME = 123;