[Scummvm-cvs-logs] CVS: scummvm/simon items.cpp,1.138,1.139 saveload.cpp,1.22,1.23 simon.cpp,1.545,1.546 verb.cpp,1.33,1.34 vga.cpp,1.160,1.161
kirben
kirben at users.sourceforge.net
Thu Nov 17 18:32:05 CET 2005
Update of /cvsroot/scummvm/scummvm/simon
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv15828/simon
Modified Files:
items.cpp saveload.cpp simon.cpp verb.cpp vga.cpp
Log Message:
Remove hard coded language values.
Index: items.cpp
===================================================================
RCS file: /cvsroot/scummvm/scummvm/simon/items.cpp,v
retrieving revision 1.138
retrieving revision 1.139
diff -u -d -r1.138 -r1.139
--- items.cpp 12 Nov 2005 08:04:10 -0000 1.138
+++ items.cpp 18 Nov 2005 02:31:24 -0000 1.139
@@ -1388,21 +1388,24 @@
byte keyNo = 'n';
switch (_language) {
- case 21: // Russian
+ case Common::RU_RUS:
break;
- case 20: // Hebrew
+ case Common::PL_POL:
+ keyYes = 't';
+ break;
+ case Common::HB_ISR:
keyYes = 'f';
break;
- case 5: // Spanish
+ case Common::ES_ESP:
keyYes = 's';
break;
- case 3: // Italian
+ case Common::IT_ITA:
keyYes = 's';
break;
- case 2: // French
+ case Common::FR_FRA:
keyYes = 'o';
break;
- case 1: // German
+ case Common::DE_DEU:
keyYes = 'j';
break;
default:
@@ -1577,7 +1580,7 @@
old_text = fcs->text_color;
fcs->text_color = fcs->fill_color;
- if (_language == 20) { //Hebrew
+ if (_language == Common::HB_ISR) { //Hebrew
x = 128;
} else {
x += 120;
Index: saveload.cpp
===================================================================
RCS file: /cvsroot/scummvm/scummvm/simon/saveload.cpp,v
retrieving revision 1.22
retrieving revision 1.23
diff -u -d -r1.22 -r1.23
--- saveload.cpp 12 Nov 2005 06:01:24 -0000 1.22
+++ saveload.cpp 18 Nov 2005 02:31:24 -0000 1.23
@@ -227,7 +227,7 @@
fcs->textRow = unk132_result;
- if (_language == 20) { //Hebrew
+ if (_language == Common::HB_ISR) { //Hebrew
// init x offset with a 2 character savegame number + a period (18 pix)
fcs->textColumn = 3;
fcs->textColumnOffset = 6;
@@ -244,7 +244,7 @@
// now process entire savegame name to get correct x offset for cursor
name_len = 0;
while (name[name_len]) {
- if (_language == 20) { //Hebrew
+ if (_language == Common::HB_ISR) { //Hebrew
byte width = 6;
if (name[name_len] >= 64 && name[name_len] < 91)
width = _hebrew_char_widths [name[name_len] - 64];
@@ -309,7 +309,7 @@
name_len--;
m = name[name_len];
- if (_language == 20) //Hebrew
+ if (_language == Common::HB_ISR) //Hebrew
x = 8;
else
x = (name[name_len] == 'i' || name[name_len] == 'l') ? 1 : 8;
Index: simon.cpp
===================================================================
RCS file: /cvsroot/scummvm/scummvm/simon/simon.cpp,v
retrieving revision 1.545
retrieving revision 1.546
diff -u -d -r1.545 -r1.546
--- simon.cpp 18 Nov 2005 01:36:14 -0000 1.545
+++ simon.cpp 18 Nov 2005 02:31:24 -0000 1.546
@@ -574,7 +574,7 @@
if ((getGameType() == GType_SIMON2) && ConfMan.hasKey("speech_mute") && ConfMan.getBool("speech_mute") == 1)
_speech = 0;
- if ((getGameType() == GType_SIMON1 && _language > 1) || ((getGameType() == GType_SIMON2) && _language == 20)) {
+ if ((getGameType() == GType_SIMON1 && _language > 1) || ((getGameType() == GType_SIMON2) && _language == Common::HB_ISR)) {
if (ConfMan.hasKey("subtitles") && ConfMan.getBool("subtitles") == 0)
_subtitles = 0;
} else
@@ -2636,7 +2636,7 @@
// caused several glitches in this scene.
// We work around the problem by correcting the code_ptr for sprite
// 200 in this scene, if it is wrong.
- if (getGameType() == GType_SIMON1 && _language == 2 &&
+ if (getGameType() == GType_SIMON1 && _language == Common::FR_FRA &&
(code_ptr - _vgaBufferPointers[cur_file].vgaFile1 == 4) && (cur_sprite == 200) && (cur_file == 2))
code_ptr += 0x66;
@@ -3444,7 +3444,7 @@
}
_skipVgaWait = true;
} else {
- if (_subtitles && _language != 20) {
+ if (_subtitles && _language != Common::HB_ISR) {
_sound->playVoice(speech_id);
return;
} else if (_subtitles && _scriptVar2) {
@@ -3990,7 +3990,7 @@
if (getFeatures() & GF_TALKIE) {
// English and German versions of Simon the Sorcerer 1 don't have full subtitles
- if (getGameType() == GType_SIMON1 && _language < 2)
+ if (getGameType() == GType_SIMON1 && (_language == Common::EN_USA || _language == Common::DE_DEU))
_subtitles = false;
} else {
_subtitles = true;
Index: verb.cpp
===================================================================
RCS file: /cvsroot/scummvm/scummvm/simon/verb.cpp,v
retrieving revision 1.33
retrieving revision 1.34
diff -u -d -r1.33 -r1.34
--- verb.cpp 12 Nov 2005 06:01:24 -0000 1.33
+++ verb.cpp 18 Nov 2005 02:31:24 -0000 1.34
@@ -221,25 +221,53 @@
if (_showPreposition) {
switch (_language) {
- case 21: verb_prep_names = russian_verb_prep_names; break;
- case 20: verb_prep_names = hebrew_verb_prep_names; break;
- case 5: verb_prep_names = spanish_verb_prep_names; break;
- case 3: verb_prep_names = italian_verb_prep_names; break;
- case 2: verb_prep_names = french_verb_prep_names; break;
- case 1: verb_prep_names = german_verb_prep_names; break;
- default: verb_prep_names = english_verb_prep_names; break;
+ case Common::RU_RUS:
+ verb_prep_names = russian_verb_prep_names;
+ break;
+ case Common::HB_ISR:
+ verb_prep_names = hebrew_verb_prep_names;
+ break;
+ case Common::ES_ESP:
+ verb_prep_names = spanish_verb_prep_names;
+ break;
+ case Common::IT_ITA:
+ verb_prep_names = italian_verb_prep_names;
+ break;
+ case Common::FR_FRA:
+ verb_prep_names = french_verb_prep_names;
+ break;
+ case Common::DE_DEU:
+ verb_prep_names = german_verb_prep_names;
+ break;
+ default:
+ verb_prep_names = english_verb_prep_names;
+ break;
}
CHECK_BOUNDS(hitarea_id, english_verb_prep_names);
txt = verb_prep_names[hitarea_id];
} else {
switch (_language) {
- case 21: verb_names = russian_verb_names; break;
- case 20: verb_names = hebrew_verb_names; break;
- case 5: verb_names = spanish_verb_names; break;
- case 3: verb_names = italian_verb_names; break;
- case 2: verb_names = french_verb_names; break;
- case 1: verb_names = german_verb_names; break;
- default: verb_names = english_verb_names; break;
+ case Common::RU_RUS:
+ verb_names = russian_verb_names;
+ break;
+ case Common::HB_ISR:
+ verb_names = hebrew_verb_names;
+ break;
+ case Common::ES_ESP:
+ verb_names = spanish_verb_names;
+ break;
+ case Common::IT_ITA:
+ verb_names = italian_verb_names;
+ break;
+ case Common::FR_FRA:
+ verb_names = french_verb_names;
+ break;
+ case Common::DE_DEU:
+ verb_names = german_verb_names;
+ break;
+ default:
+ verb_names = english_verb_names;
+ break;
}
CHECK_BOUNDS(hitarea_id, english_verb_names);
txt = verb_names[hitarea_id];
Index: vga.cpp
===================================================================
RCS file: /cvsroot/scummvm/scummvm/simon/vga.cpp,v
retrieving revision 1.160
retrieving revision 1.161
diff -u -d -r1.160 -r1.161
--- vga.cpp 15 Nov 2005 21:38:26 -0000 1.160
+++ vga.cpp 18 Nov 2005 02:31:24 -0000 1.161
@@ -1914,7 +1914,7 @@
void SimonEngine::vc64_skipIfSpeechEnded() {
// Simon2
- if (!_sound->isVoiceActive() || (_subtitles && _language != 20))
+ if (!_sound->isVoiceActive() || (_subtitles && _language != Common::HB_ISR))
vc_skip_next_instruction();
}
More information about the Scummvm-git-logs
mailing list