[Scummvm-cvs-logs] SF.net SVN: scummvm: [21585] scummvm/trunk/engines/simon/icons.cpp

eriktorbjorn at users.sourceforge.net eriktorbjorn at users.sourceforge.net
Mon Apr 3 23:26:05 CEST 2006


Revision: 21585
Author:   eriktorbjorn
Date:     2006-04-03 23:25:50 -0700 (Mon, 03 Apr 2006)
ViewCVS:  http://svn.sourceforge.net/scummvm/?rev=21585&view=rev

Log Message:
-----------
Work around glitchy drawing of the Oracle icon, after discussing with Kirben.
But it's still unclear *why* the first 16 bytes should be skipped; hence the
Big Scary Comment (tm).

Modified Paths:
--------------
    scummvm/trunk/engines/simon/icons.cpp
Modified: scummvm/trunk/engines/simon/icons.cpp
===================================================================
--- scummvm/trunk/engines/simon/icons.cpp	2006-04-04 02:41:45 UTC (rev 21584)
+++ scummvm/trunk/engines/simon/icons.cpp	2006-04-04 06:25:50 UTC (rev 21585)
@@ -55,8 +55,14 @@
 void SimonEngine::loadIconData() {
 	loadZone(8);
 	VgaPointersEntry *vpe = &_vgaBufferPointers[8];
-	byte *src = vpe->vgaFile2;
 
+	// FIXME: For reasons unknown, the first 16 bytes are not part of the
+	// actual image data. This could be an indication of some deeper
+	// problem elsewhere. For now, adding 16 fixes the drawing of the
+	// Oracle icon.
+
+	byte *src = vpe->vgaFile2 + 16;
+
 	_iconFilePtr = (byte *)malloc(43 * 336);
 	if (_iconFilePtr == NULL)
 		error("Out of icon memory");


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.





More information about the Scummvm-git-logs mailing list