[Scummvm-cvs-logs] SF.net SVN: scummvm: [21808] scummvm/trunk/engines/scumm/plugin.cpp
eriktorbjorn at users.sourceforge.net
eriktorbjorn at users.sourceforge.net
Tue Apr 11 12:43:03 CEST 2006
Revision: 21808
Author: eriktorbjorn
Date: 2006-04-11 12:29:55 -0700 (Tue, 11 Apr 2006)
ViewCVS: http://svn.sourceforge.net/scummvm/?rev=21808&view=rev
Log Message:
-----------
If generateDetectName() generates an empty string, that's a failure, not a
success. Otherwise ScummVM will crash once the game detector reaches the
"generic HE game variants", which makes it hard to add non-SCUMM games.
Modified Paths:
--------------
scummvm/trunk/engines/scumm/plugin.cpp
Modified: scummvm/trunk/engines/scumm/plugin.cpp
===================================================================
--- scummvm/trunk/engines/scumm/plugin.cpp 2006-04-11 18:26:40 UTC (rev 21807)
+++ scummvm/trunk/engines/scumm/plugin.cpp 2006-04-11 19:29:55 UTC (rev 21808)
@@ -1278,7 +1278,7 @@
case 5:
// FIXME: Fingolfin asks: For which games is this case used?
// Please document this. Also: Why was this case missing in
- // Engine_SCUMM_create ?
+ // Engine_SCUMM_create ?
strcpy(detectName, g.gameid);
break;
case 6:
@@ -1296,6 +1296,9 @@
return false;
}
+ if (!detectName[0])
+ return false;
+
return true;
}
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
More information about the Scummvm-git-logs
mailing list