[Scummvm-cvs-logs] SF.net SVN: scummvm: [22192] scummvm/trunk/backends/fs/windows/windows-fs.cpp

fingolfin at users.sourceforge.net fingolfin at users.sourceforge.net
Thu Apr 27 10:22:03 CEST 2006


Revision: 22192
Author:   fingolfin
Date:     2006-04-27 10:21:33 -0700 (Thu, 27 Apr 2006)
ViewCVS:  http://svn.sourceforge.net/scummvm/?rev=22192&view=rev

Log Message:
-----------
I still don't know whether this is the correct fix for WindowsFilesystemNode, but at least with it, one definite and serious bug in the code (using an uninitialised variable) has been fixed, the end result hardly will be worse

Modified Paths:
--------------
    scummvm/trunk/backends/fs/windows/windows-fs.cpp
Modified: scummvm/trunk/backends/fs/windows/windows-fs.cpp
===================================================================
--- scummvm/trunk/backends/fs/windows/windows-fs.cpp	2006-04-27 04:59:13 UTC (rev 22191)
+++ scummvm/trunk/backends/fs/windows/windows-fs.cpp	2006-04-27 17:21:33 UTC (rev 22192)
@@ -158,6 +158,10 @@
 		_isValid = true;
 		_isDirectory = ((fileAttribs & FILE_ATTRIBUTE_DIRECTORY) != 0);
 	}
+	// FIXME: Is the following correct? Should we maybe check for path being
+	// empty and set it to true in this case?
+	// In any case, not setting _isPseudoRoot at all certainly is a bug.
+	_isPseudoRoot = false;
 }
 
 FSList WindowsFilesystemNode::listDir(ListMode mode) const {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.





More information about the Scummvm-git-logs mailing list