[Scummvm-cvs-logs] SF.net SVN: scummvm: [23285] scummvm/trunk/engines/agi

[fingolfin at users.sourceforge.net]

Revision: 23285
Author:   fingolfin
Date:     2006-06-24 03:45:47 -0700 (Sat, 24 Jun 2006)
ViewCVS:  http://svn.sourceforge.net/scummvm/?rev=23285&view=rev

Log Message:
-----------
Added some FIXME comments to AGI engine

Modified Paths:
--------------
    scummvm/trunk/engines/agi/agi.cpp
    scummvm/trunk/engines/agi/savegame.cpp
Modified: scummvm/trunk/engines/agi/agi.cpp
===================================================================
--- scummvm/trunk/engines/agi/agi.cpp	2006-06-24 10:14:18 UTC (rev 23284)
+++ scummvm/trunk/engines/agi/agi.cpp	2006-06-24 10:45:47 UTC (rev 23285)
@@ -434,7 +434,7 @@
 	return loader->unload_resource(r, n);
 }
 
-const char *_savePath;
+const char *_savePath;	// FIXME: Get rid of this
 extern AGIMusic *g_agi_music;
 
 struct GameSettings {
@@ -462,7 +462,7 @@
 	_mixer->setVolumeForSoundType(Audio::Mixer::kSFXSoundType, ConfMan.getInt("sfx_volume"));
 	_mixer->setVolumeForSoundType(Audio::Mixer::kMusicSoundType, ConfMan.getInt("music_volume"));
 
-	_savePath = _saveFileMan->getSavePath();
+	_savePath = _saveFileMan->getSavePath();	// FIXME: Get rid of this
 
 	const GameSettings *g;
 

Modified: scummvm/trunk/engines/agi/savegame.cpp
===================================================================
--- scummvm/trunk/engines/agi/savegame.cpp	2006-06-24 10:14:18 UTC (rev 23284)
+++ scummvm/trunk/engines/agi/savegame.cpp	2006-06-24 10:45:47 UTC (rev 23285)
@@ -126,6 +126,9 @@
 
 static const char *strSig = "AGI:";
 
+// FIXME: The following wrapper methods are not needed, since class File
+// (resp. class Stream) already offers similar methods.
+
 static void write_uint8(Common::File *f, int8 val) {
 	f->write(&val, 1);
 }
@@ -192,6 +195,7 @@
 	struct image_stack_element *ptr = image_stack;
 	Common::File f;
 
+	// FIXME: Do *not* use Common::File to access savegames, it is not portable!
 	f.open(s, Common::File::kFileWriteMode);
 
 	if (!f.isOpen())
@@ -354,6 +358,7 @@
 	char description[256];
 	Common::File f;
 
+	// FIXME: Do *not* use Common::File to access savegames, it is not portable!
 	f.open(s);
 
 	if (!f.isOpen())
@@ -587,6 +592,7 @@
 		char name[MAX_PATH];
 		Common::File f;
 		char sig[8];
+		// FIXME: Do *not* use Common::File to access savegames, it is not portable!
 		sprintf(name, "%s/%05X_%s_%02d.sav", _savePath, game.crc, game.id, i);
 		f.open(name);
 		if (!f.isOpen()) {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.