[Scummvm-cvs-logs] SF.net SVN: scummvm: [22531] scummvm/trunk/engines/kyra

[fingolfin at users.sourceforge.net]

Revision: 22531
Author:   fingolfin
Date:     2006-05-19 00:20:27 -0700 (Fri, 19 May 2006)
ViewCVS:  http://svn.sourceforge.net/scummvm/?rev=22531&view=rev

Log Message:
-----------
Added some FIXMEs to the kyra engine

Modified Paths:
--------------
    scummvm/trunk/engines/kyra/kyra.cpp
    scummvm/trunk/engines/kyra/kyra3.cpp
Modified: scummvm/trunk/engines/kyra/kyra.cpp
===================================================================
--- scummvm/trunk/engines/kyra/kyra.cpp	2006-05-19 07:12:38 UTC (rev 22530)
+++ scummvm/trunk/engines/kyra/kyra.cpp	2006-05-19 07:20:27 UTC (rev 22531)
@@ -363,11 +363,12 @@
 }
 
 KyraEngine_v1::~KyraEngine_v1() {
+	// FIXME: I am leaking badly!
 
 }
 
 KyraEngine_v2::~KyraEngine_v2() {
-
+	// FIXME: I am leaking badly!
 }
 
 void KyraEngine::errorString(const char *buf1, char *buf2) {
@@ -399,7 +400,7 @@
 		resetGameFlag(0xEF);
 		mainLoop();
 	}
-	quitGame();
+	quitGame();	// FIXME: You shouldn't quit here, just return to the caller!
 	return 0;
 }
 
@@ -546,6 +547,7 @@
 }
 
 void KyraEngine::quitGame() {
+	// FIXME: The code of this method should probably be moved to the destructor.
 	debugC(9, kDebugLevelMain, "KyraEngine::quitGame()");
 
 	for (int i = 0; i < ARRAYSIZE(_movieObjects); ++i) {
@@ -560,6 +562,7 @@
 
 	Common::clearAllSpecialDebugLevels();
 
+	// FIXME: Do not use OSystem::quit() unless you have to !
 	_system->quit();
 }
 

Modified: scummvm/trunk/engines/kyra/kyra3.cpp
===================================================================
--- scummvm/trunk/engines/kyra/kyra3.cpp	2006-05-19 07:12:38 UTC (rev 22530)
+++ scummvm/trunk/engines/kyra/kyra3.cpp	2006-05-19 07:20:27 UTC (rev 22531)
@@ -36,6 +36,7 @@
 }
 
 KyraEngine_v3::~KyraEngine_v3() {
+	delete _soundDigital;
 }
 
 Movie *KyraEngine_v3::createWSAMovie() {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.