[Scummvm-cvs-logs] SF.net SVN: scummvm: [22685] scummvm/trunk/gui/about.cpp

[wjpalenstijn at users.sourceforge.net]

Revision: 22685
Author:   wjpalenstijn
Date:     2006-05-27 07:41:15 -0700 (Sat, 27 May 2006)
ViewCVS:  http://svn.sourceforge.net/scummvm/?rev=22685&view=rev

Log Message:
-----------
add fixme about scrolling in about dialog

Modified Paths:
--------------
    scummvm/trunk/gui/about.cpp
Modified: scummvm/trunk/gui/about.cpp
===================================================================
--- scummvm/trunk/gui/about.cpp	2006-05-27 13:52:30 UTC (rev 22684)
+++ scummvm/trunk/gui/about.cpp	2006-05-27 14:41:15 UTC (rev 22685)
@@ -191,6 +191,11 @@
 	//       in the right way. Should be even faster...
 	const int firstLine = _scrollPos / _lineHeight;
 	const int lastLine = MIN((_scrollPos + _h) / _lineHeight + 1, (uint32)_lines.size());
+	// FIXME: There's some confusion here about the meaning of 'yOff'.
+	//        The setDrawArea call above makes it possible to render text
+	//        vertically from _y to _y+_h, while the line below assumes text
+	//        is drawn from _y+yOff down. This causes leftover pixels
+	//        the top while scrolling.
 	int y = _y + yOff - (_scrollPos % _lineHeight);
 
 	for (int line = firstLine; line < lastLine; line++) {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.