[Scummvm-cvs-logs] SF.net SVN: scummvm: [24693] scummvm/trunk/engines/queen

cyx at users.sourceforge.net cyx at users.sourceforge.net
Sun Nov 12 18:47:38 CET 2006


Revision: 24693
          http://svn.sourceforge.net/scummvm/?rev=24693&view=rev
Author:   cyx
Date:     2006-11-12 09:47:16 -0800 (Sun, 12 Nov 2006)

Log Message:
-----------
cleanup

Modified Paths:
--------------
    scummvm/trunk/engines/queen/bankman.h
    scummvm/trunk/engines/queen/command.cpp
    scummvm/trunk/engines/queen/command.h
    scummvm/trunk/engines/queen/credits.h
    scummvm/trunk/engines/queen/cutaway.h
    scummvm/trunk/engines/queen/debug.h
    scummvm/trunk/engines/queen/defs.h
    scummvm/trunk/engines/queen/display.h
    scummvm/trunk/engines/queen/graphics.h
    scummvm/trunk/engines/queen/grid.h
    scummvm/trunk/engines/queen/input.h
    scummvm/trunk/engines/queen/journal.h
    scummvm/trunk/engines/queen/logic.cpp
    scummvm/trunk/engines/queen/logic.h
    scummvm/trunk/engines/queen/music.h
    scummvm/trunk/engines/queen/queen.cpp
    scummvm/trunk/engines/queen/resource.h
    scummvm/trunk/engines/queen/sound.h
    scummvm/trunk/engines/queen/state.h
    scummvm/trunk/engines/queen/structs.h
    scummvm/trunk/engines/queen/walk.h

Modified: scummvm/trunk/engines/queen/bankman.h
===================================================================
--- scummvm/trunk/engines/queen/bankman.h	2006-11-12 17:39:47 UTC (rev 24692)
+++ scummvm/trunk/engines/queen/bankman.h	2006-11-12 17:47:16 UTC (rev 24693)
@@ -20,8 +20,8 @@
  *
  */
 
-#ifndef QUEENBANKMAN_H
-#define QUEENBANKMAN_H
+#ifndef QUEEN_BANKMAN_H
+#define QUEEN_BANKMAN_H
 
 #include "common/util.h"
 #include "queen/structs.h"

Modified: scummvm/trunk/engines/queen/command.cpp
===================================================================
--- scummvm/trunk/engines/queen/command.cpp	2006-11-12 17:39:47 UTC (rev 24692)
+++ scummvm/trunk/engines/queen/command.cpp	2006-11-12 17:47:16 UTC (rev 24693)
@@ -36,8 +36,9 @@
 
 namespace Queen {
 
-CmdText::CmdText(bool reversed, uint8 y, QueenEngine *vm)
-	: _isReversed(reversed), _y(y), _vm(vm) {
+CmdText::CmdText(uint8 y, QueenEngine *vm)
+	: _y(y), _vm(vm) {
+	_isReversed = (_vm->resource()->getLanguage() == Common::HB_ISR);
 	clear();
 }
 
@@ -124,7 +125,7 @@
 
 Command::Command(QueenEngine *vm)
 	: _cmdList(NULL), _cmdArea(NULL), _cmdObject(NULL), _cmdInventory(NULL), _cmdGameState(NULL),
-	_cmdText((vm->resource()->getLanguage() == Common::HB_ISR), CmdText::COMMAND_Y_POS, vm), _vm(vm) {
+	_cmdText(CmdText::COMMAND_Y_POS, vm), _vm(vm) {
 }
 
 Command::~Command() {
@@ -214,7 +215,7 @@
 		// Joe is stuck behind the waterfall due to a walkbox issue. We could
 		// fix the walkbox issue, but then Joe would walk through the waterfall
 		// which wouldn't look that nice, graphically.
-		//		
+		//
 		// Since this command isn't necessary to complete the game and doesn't
 		// really makes sense here, we just skip it for now. The same cutscene
 		// is already played in command 648, so the user don't miss anything
@@ -225,7 +226,7 @@
 		if (comId == 649) {
 			continue;
 		}
-				
+
 		com = &_cmdList[comId];
 
 		// check the Gamestates and set them if necessary

Modified: scummvm/trunk/engines/queen/command.h
===================================================================
--- scummvm/trunk/engines/queen/command.h	2006-11-12 17:39:47 UTC (rev 24692)
+++ scummvm/trunk/engines/queen/command.h	2006-11-12 17:47:16 UTC (rev 24693)
@@ -20,8 +20,8 @@
  *
  */
 
-#ifndef QUEENCOMMAND_H
-#define QUEENCOMMAND_H
+#ifndef QUEEN_COMMAND_H
+#define QUEEN_COMMAND_H
 
 #include "common/util.h"
 #include "queen/structs.h"
@@ -32,7 +32,7 @@
 
 struct CmdText {
 
-	CmdText(bool reversed, uint8 y, QueenEngine *vm);
+	CmdText(uint8 y, QueenEngine *vm);
 
 	//! reset the command sentence
 	void clear();

Modified: scummvm/trunk/engines/queen/credits.h
===================================================================
--- scummvm/trunk/engines/queen/credits.h	2006-11-12 17:39:47 UTC (rev 24692)
+++ scummvm/trunk/engines/queen/credits.h	2006-11-12 17:47:16 UTC (rev 24693)
@@ -20,8 +20,8 @@
  *
  */
 
-#ifndef CREDITS_H
-#define CREDITS_H
+#ifndef QUEEN_CREDITS_H
+#define QUEEN_CREDITS_H
 
 #include "common/util.h"
 #include "queen/defs.h"

Modified: scummvm/trunk/engines/queen/cutaway.h
===================================================================
--- scummvm/trunk/engines/queen/cutaway.h	2006-11-12 17:39:47 UTC (rev 24692)
+++ scummvm/trunk/engines/queen/cutaway.h	2006-11-12 17:47:16 UTC (rev 24693)
@@ -20,8 +20,8 @@
  *
  */
 
-#ifndef QUEENCUTAWAY_H
-#define QUEENCUTAWAY_H
+#ifndef QUEEN_CUTAWAY_H
+#define QUEEN_CUTAWAY_H
 
 #include "common/util.h"
 #include "queen/structs.h"

Modified: scummvm/trunk/engines/queen/debug.h
===================================================================
--- scummvm/trunk/engines/queen/debug.h	2006-11-12 17:39:47 UTC (rev 24692)
+++ scummvm/trunk/engines/queen/debug.h	2006-11-12 17:47:16 UTC (rev 24693)
@@ -20,8 +20,8 @@
  *
  */
 
-#ifndef QUEENDEBUG_H
-#define QUEENDEBUG_H
+#ifndef QUEEN_DEBUG_H
+#define QUEEN_DEBUG_H
 
 #include "gui/debugger.h"
 

Modified: scummvm/trunk/engines/queen/defs.h
===================================================================
--- scummvm/trunk/engines/queen/defs.h	2006-11-12 17:39:47 UTC (rev 24692)
+++ scummvm/trunk/engines/queen/defs.h	2006-11-12 17:47:16 UTC (rev 24693)
@@ -20,8 +20,8 @@
  *
  */
 
-#ifndef QUEENDEFS_H
-#define QUEENDEFS_H
+#ifndef QUEEN_DEFS_H
+#define QUEEN_DEFS_H
 
 namespace Queen {
 

Modified: scummvm/trunk/engines/queen/display.h
===================================================================
--- scummvm/trunk/engines/queen/display.h	2006-11-12 17:39:47 UTC (rev 24692)
+++ scummvm/trunk/engines/queen/display.h	2006-11-12 17:47:16 UTC (rev 24693)
@@ -20,8 +20,8 @@
  *
  */
 
-#ifndef QUEENDISPLAY_H
-#define QUEENDISPLAY_H
+#ifndef QUEEN_DISPLAY_H
+#define QUEEN_DISPLAY_H
 
 #include "common/str.h"
 #include "common/util.h"
@@ -151,7 +151,7 @@
 
 	//! change the text color for the specified texts list entry
 	void textColor(uint16 y, uint8 color) { _texts[y].color = color; }
-	
+
 	//! Set the focus rectangle to the speaking character
 	void setFocusRect(const Common::Rect& rect);
 

Modified: scummvm/trunk/engines/queen/graphics.h
===================================================================
--- scummvm/trunk/engines/queen/graphics.h	2006-11-12 17:39:47 UTC (rev 24692)
+++ scummvm/trunk/engines/queen/graphics.h	2006-11-12 17:47:16 UTC (rev 24693)
@@ -20,8 +20,8 @@
  *
  */
 
-#ifndef QUEENGRAPHICS_H
-#define QUEENGRAPHICS_H
+#ifndef QUEEN_GRAPHICS_H
+#define QUEEN_GRAPHICS_H
 
 #include "common/util.h"
 #include "queen/structs.h"

Modified: scummvm/trunk/engines/queen/grid.h
===================================================================
--- scummvm/trunk/engines/queen/grid.h	2006-11-12 17:39:47 UTC (rev 24692)
+++ scummvm/trunk/engines/queen/grid.h	2006-11-12 17:47:16 UTC (rev 24693)
@@ -20,8 +20,8 @@
  *
  */
 
-#ifndef QUEENGRID_H
-#define QUEENGRID_H
+#ifndef QUEEN_GRID_H
+#define QUEEN_GRID_H
 
 #include "common/util.h"
 #include "queen/structs.h"

Modified: scummvm/trunk/engines/queen/input.h
===================================================================
--- scummvm/trunk/engines/queen/input.h	2006-11-12 17:39:47 UTC (rev 24692)
+++ scummvm/trunk/engines/queen/input.h	2006-11-12 17:47:16 UTC (rev 24693)
@@ -20,8 +20,8 @@
  *
  */
 
-#ifndef INPUT_H
-#define INPUT_H
+#ifndef QUEEN_INPUT_H
+#define QUEEN_INPUT_H
 
 #include "common/util.h"
 #include "queen/defs.h"

Modified: scummvm/trunk/engines/queen/journal.h
===================================================================
--- scummvm/trunk/engines/queen/journal.h	2006-11-12 17:39:47 UTC (rev 24692)
+++ scummvm/trunk/engines/queen/journal.h	2006-11-12 17:47:16 UTC (rev 24693)
@@ -20,8 +20,8 @@
  *
  */
 
-#ifndef QUEENJOURNAL_H
-#define QUEENJOURNAL_H
+#ifndef QUEEN_JOURNAL_H
+#define QUEEN_JOURNAL_H
 
 #include "common/util.h"
 

Modified: scummvm/trunk/engines/queen/logic.cpp
===================================================================
--- scummvm/trunk/engines/queen/logic.cpp	2006-11-12 17:39:47 UTC (rev 24692)
+++ scummvm/trunk/engines/queen/logic.cpp	2006-11-12 17:47:16 UTC (rev 24693)
@@ -70,7 +70,7 @@
 	_puzzleAttemptCount = 0;
 	_journal = new Journal(vm);
 	_scene = 0;
-	initialise();
+	readQueenJas();
 }
 
 Logic::~Logic() {
@@ -88,7 +88,7 @@
 	delete[] _graphicAnim;
 }
 
-void Logic::initialise() {
+void Logic::readQueenJas() {
 	int16 i;
 
 	uint8 *jas = _vm->resource()->loadFile("QUEEN.JAS", 20);
@@ -1232,7 +1232,7 @@
 
 	_entryObj = 0;
 	uint16 prevObj = 0;
-	CmdText cmdText((_vm->resource()->getLanguage() == Common::HB_ISR), 5, _vm);
+	CmdText cmdText(5, _vm);
 	cmdText.setVerb(VERB_WALK_TO);
 	while (_vm->input()->mouseButton() == 0 || _entryObj == 0) {
 

Modified: scummvm/trunk/engines/queen/logic.h
===================================================================
--- scummvm/trunk/engines/queen/logic.h	2006-11-12 17:39:47 UTC (rev 24692)
+++ scummvm/trunk/engines/queen/logic.h	2006-11-12 17:47:16 UTC (rev 24693)
@@ -20,8 +20,8 @@
  *
  */
 
-#ifndef QUEENLOGIC_H
-#define QUEENLOGIC_H
+#ifndef QUEEN_LOGIC_H
+#define QUEEN_LOGIC_H
 
 #include "common/str.h"
 #include "common/util.h"
@@ -224,7 +224,7 @@
 
 protected:
 
-	void initialise();
+	void readQueenJas();
 
 	void asmMakeJoeUseDress();
 	void asmMakeJoeUseNormalClothes();

Modified: scummvm/trunk/engines/queen/music.h
===================================================================
--- scummvm/trunk/engines/queen/music.h	2006-11-12 17:39:47 UTC (rev 24692)
+++ scummvm/trunk/engines/queen/music.h	2006-11-12 17:47:16 UTC (rev 24693)
@@ -20,8 +20,8 @@
  *
  */
 
-#ifndef QUEENMUSIC_H
-#define QUEENMUSIC_H
+#ifndef QUEEN_MUSIC_H
+#define QUEEN_MUSIC_H
 
 #include "common/util.h"
 #include "sound/mididrv.h"

Modified: scummvm/trunk/engines/queen/queen.cpp
===================================================================
--- scummvm/trunk/engines/queen/queen.cpp	2006-11-12 17:39:47 UTC (rev 24692)
+++ scummvm/trunk/engines/queen/queen.cpp	2006-11-12 17:47:16 UTC (rev 24693)
@@ -80,7 +80,7 @@
 			}
 			Queen::DetectedGameVersion version;
 			if (Queen::Resource::detectVersion(&version, &dataFile)) {
-				DetectedGame dg(queenGameDescriptor.gameid, queenGameDescriptor.description, version.language, Common::kPlatformPC);
+				DetectedGame dg(queenGameDescriptor, version.language, Common::kPlatformPC);
 				if (version.features & Queen::GF_DEMO) {
 					dg.updateDesc("Demo");
 				} else if (version.features & Queen::GF_INTERVIEW) {

Modified: scummvm/trunk/engines/queen/resource.h
===================================================================
--- scummvm/trunk/engines/queen/resource.h	2006-11-12 17:39:47 UTC (rev 24692)
+++ scummvm/trunk/engines/queen/resource.h	2006-11-12 17:47:16 UTC (rev 24693)
@@ -20,8 +20,8 @@
  *
  */
 
-#ifndef QUEENRESOURCE_H
-#define QUEENRESOURCE_H
+#ifndef QUEEN_RESOURCE_H
+#define QUEEN_RESOURCE_H
 
 #include "common/file.h"
 #include "common/util.h"
@@ -73,10 +73,10 @@
 	//! returns a reference to a sound file
 	Common::File *giveCompressedSound(const char *filename, uint32 *size);
 
-	bool isDemo() const { return _version.features & GF_DEMO; }
-	bool isInterview() const { return _version.features & GF_INTERVIEW; }
-	bool isFloppy() const { return _version.features & GF_FLOPPY; }
-	bool isCD() const { return _version.features & GF_TALKIE; }
+	bool isDemo() const { return (_version.features & GF_DEMO) != 0; }
+	bool isInterview() const { return (_version.features & GF_INTERVIEW) != 0; }
+	bool isFloppy() const { return (_version.features & GF_FLOPPY) != 0; }
+	bool isCD() const { return (_version.features & GF_TALKIE) != 0; }
 
 	//! returns compression type for audio files
 	uint8 getCompression() const { return _version.compression; }

Modified: scummvm/trunk/engines/queen/sound.h
===================================================================
--- scummvm/trunk/engines/queen/sound.h	2006-11-12 17:39:47 UTC (rev 24692)
+++ scummvm/trunk/engines/queen/sound.h	2006-11-12 17:47:16 UTC (rev 24693)
@@ -20,8 +20,8 @@
  *
  */
 
-#ifndef QUEENSOUND_H
-#define QUEENSOUND_H
+#ifndef QUEEN_SOUND_H
+#define QUEEN_SOUND_H
 
 #include "common/util.h"
 #include "sound/mixer.h"

Modified: scummvm/trunk/engines/queen/state.h
===================================================================
--- scummvm/trunk/engines/queen/state.h	2006-11-12 17:39:47 UTC (rev 24692)
+++ scummvm/trunk/engines/queen/state.h	2006-11-12 17:47:16 UTC (rev 24693)
@@ -20,8 +20,8 @@
  *
  */
 
-#ifndef QUEENSTATE_H
-#define QUEENSTATE_H
+#ifndef QUEEN_STATE_H
+#define QUEEN_STATE_H
 
 #include "common/util.h"
 #include "queen/defs.h"

Modified: scummvm/trunk/engines/queen/structs.h
===================================================================
--- scummvm/trunk/engines/queen/structs.h	2006-11-12 17:39:47 UTC (rev 24692)
+++ scummvm/trunk/engines/queen/structs.h	2006-11-12 17:47:16 UTC (rev 24693)
@@ -20,8 +20,8 @@
  *
  */
 
-#ifndef QUEENSTRUCTS_H
-#define QUEENSTRUCTS_H
+#ifndef QUEEN_STRUCTS_H
+#define QUEEN_STRUCTS_H
 
 #include "queen/defs.h"
 #include "common/endian.h"

Modified: scummvm/trunk/engines/queen/walk.h
===================================================================
--- scummvm/trunk/engines/queen/walk.h	2006-11-12 17:39:47 UTC (rev 24692)
+++ scummvm/trunk/engines/queen/walk.h	2006-11-12 17:47:16 UTC (rev 24693)
@@ -20,8 +20,8 @@
  *
  */
 
-#ifndef QUEENWALK_H
-#define QUEENWALK_H
+#ifndef QUEEN_WALK_H
+#define QUEEN_WALK_H
 
 #include "common/util.h"
 #include "queen/structs.h"


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.




More information about the Scummvm-git-logs mailing list