[Scummvm-cvs-logs] SF.net SVN: scummvm: [26676] scummvm/trunk/engines/scumm/vars.cpp

fingolfin at users.sourceforge.net fingolfin at users.sourceforge.net
Sun Apr 29 14:20:36 CEST 2007


Revision: 26676
          http://scummvm.svn.sourceforge.net/scummvm/?rev=26676&view=rev
Author:   fingolfin
Date:     2007-04-29 05:20:35 -0700 (Sun, 29 Apr 2007)

Log Message:
-----------
Hard crash when not using adlib/pcspk in a Loom/MonkeyEGA is not nice, we should try to add a safe fallback mode at some point

Modified Paths:
--------------
    scummvm/trunk/engines/scumm/vars.cpp

Modified: scummvm/trunk/engines/scumm/vars.cpp
===================================================================
--- scummvm/trunk/engines/scumm/vars.cpp	2007-04-29 11:30:29 UTC (rev 26675)
+++ scummvm/trunk/engines/scumm/vars.cpp	2007-04-29 12:20:35 UTC (rev 26676)
@@ -712,12 +712,16 @@
 					Common::File f;
 					for (int i = 82; i < 85; i++) {
 						sprintf(buf, "%d.LFL", i);
-						if (!Common::File::exists(buf))
+						if (!Common::File::exists(buf)) {
+							// TODO: Instead of a hard error, try to fall back to adlib?
 							error("Native MIDI support requires Roland patch from LucasArts, but %s is missing", buf);
+						}
 					}
 				} else if (_game.id == GID_MONKEY_EGA) {
-					if (!Common::File::exists("DISK09.LEC"))
+					if (!Common::File::exists("DISK09.LEC")) {
+						// TODO: Instead of a hard error, try to fall back to adlib?
 						error("Native MIDI support requires Roland patch from LucasArts, but DISK09.LEC is missing");
+					}
 				}
 				VAR(VAR_SOUNDCARD) = 4;
 			} else {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.




More information about the Scummvm-git-logs mailing list