[Scummvm-cvs-logs] SF.net SVN: scummvm: [28682] scummvm/trunk/engines/saga
thebluegr at users.sourceforge.net
thebluegr at users.sourceforge.net
Mon Aug 20 22:00:40 CEST 2007
Revision: 28682
http://scummvm.svn.sourceforge.net/scummvm/?rev=28682&view=rev
Author: thebluegr
Date: 2007-08-20 13:00:40 -0700 (Mon, 20 Aug 2007)
Log Message:
-----------
Cleanup: Removed obsolete TODOs
Modified Paths:
--------------
scummvm/trunk/engines/saga/displayinfo.h
scummvm/trunk/engines/saga/interface.cpp
scummvm/trunk/engines/saga/itedata.h
scummvm/trunk/engines/saga/saveload.cpp
scummvm/trunk/engines/saga/scene.cpp
Modified: scummvm/trunk/engines/saga/displayinfo.h
===================================================================
--- scummvm/trunk/engines/saga/displayinfo.h 2007-08-20 19:49:31 UTC (rev 28681)
+++ scummvm/trunk/engines/saga/displayinfo.h 2007-08-20 20:00:40 UTC (rev 28682)
@@ -280,7 +280,7 @@
};
-//TODO: ihnm
+// IHNM
#define IHNM_CONVERSE_MAX_TEXT_WIDTH (485 - 8)
#define IHNM_CONVERSE_TEXT_HEIGHT 10
#define IHNM_CONVERSE_TEXT_LINES 11
@@ -354,7 +354,6 @@
};
static PanelButton IHNM_SavePanelButtons[] = {
- // TODO
{kPanelButtonSave, 25,79, 80,25, kTextSave,'s',0, 0,0,0},
{kPanelButtonSave, 155,79, 80,25, kTextCancel,'c',0, 0,0,0},
{kPanelButtonSaveEdit, 26,57, 209,17, 0,'-',0, 0,0,0},
Modified: scummvm/trunk/engines/saga/interface.cpp
===================================================================
--- scummvm/trunk/engines/saga/interface.cpp 2007-08-20 19:49:31 UTC (rev 28681)
+++ scummvm/trunk/engines/saga/interface.cpp 2007-08-20 20:00:40 UTC (rev 28682)
@@ -420,8 +420,8 @@
switch (_panelMode) {
case kPanelMain:
- if (_vm->getGameType() == GType_IHNM)
- warning("FIXME: Implement IHNM differences from ExecuteInventoryPanel");
+ // FIXME: Implement IHNM differences from ExecuteInventoryPanel for IHNM (though I believe they're already
+ // implemented)
_mainPanel.currentButton = NULL;
break;
Modified: scummvm/trunk/engines/saga/itedata.h
===================================================================
--- scummvm/trunk/engines/saga/itedata.h 2007-08-20 19:49:31 UTC (rev 28681)
+++ scummvm/trunk/engines/saga/itedata.h 2007-08-20 20:00:40 UTC (rev 28682)
@@ -41,9 +41,6 @@
kNoScale = 0x80 // (1<<7) Actor is not scaled
};
-// TODO: This doesn't quite correspond to the original Actor struct, so I'm not
-// sure if I got it right.
-
struct ActorTableData {
byte flags;
byte nameIndex;
Modified: scummvm/trunk/engines/saga/saveload.cpp
===================================================================
--- scummvm/trunk/engines/saga/saveload.cpp 2007-08-20 19:49:31 UTC (rev 28681)
+++ scummvm/trunk/engines/saga/saveload.cpp 2007-08-20 20:00:40 UTC (rev 28682)
@@ -237,8 +237,8 @@
// Some older saves were not written in an endian safe fashion.
// We try to detect this here by checking for extremly high version values.
// If found, we retry with the data swapped.
- // FIXME: Maybe display a warning/error message instead?
if (_saveHeader.version > 0xFFFFFF) {
+ warning("This savegame is not endian safe, retrying with the data swapped");
_saveHeader.version = SWAP_BYTES_32(_saveHeader.version);
}
Modified: scummvm/trunk/engines/saga/scene.cpp
===================================================================
--- scummvm/trunk/engines/saga/scene.cpp 2007-08-20 19:49:31 UTC (rev 28681)
+++ scummvm/trunk/engines/saga/scene.cpp 2007-08-20 20:00:40 UTC (rev 28682)
@@ -811,11 +811,6 @@
_vm->_sound->stopAll();
- // FIXME: Does IHNM use scene background music, or is all the
- // music scripted? At the very least, it shouldn't try
- // to start song 0 at the beginning of the game, since
- // it's the end credits music.
-
if (_vm->getGameType() == GType_ITE) {
if (_sceneDescription.musicResourceId >= 0) {
event.type = kEvTOneshot;
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
More information about the Scummvm-git-logs
mailing list