[Scummvm-cvs-logs] SF.net SVN: scummvm: [29930] scummvm/trunk/engines/agi/agi.cpp

[fingolfin at users.sourceforge.net]

Revision: 29930
          http://scummvm.svn.sourceforge.net/scummvm/?rev=29930&view=rev
Author:   fingolfin
Date:     2007-12-20 14:14:50 -0800 (Thu, 20 Dec 2007)

Log Message:
-----------
Clarify AGI FIXME

Modified Paths:
--------------
    scummvm/trunk/engines/agi/agi.cpp

Modified: scummvm/trunk/engines/agi/agi.cpp
===================================================================
--- scummvm/trunk/engines/agi/agi.cpp	2007-12-20 19:17:00 UTC (rev 29929)
+++ scummvm/trunk/engines/agi/agi.cpp	2007-12-20 22:14:50 UTC (rev 29930)
@@ -220,7 +220,12 @@
 				break;
 			default:
 				// FIXME: This fixes assertions with isalpha below, but it essentially filters
-				// out all function keys (control, alt and shift)
+				// out all function keys (control, alt and shift).
+				// Well, actually, it does *not* filter them out (as we still pass the value
+				// in key to keyEnqueue after this switch/case statement); but it means that
+				// we perform no filtering on these input events, which is bad. That is, we 
+				// provide keycode in one format, and the AGI core expects some other format...
+				// So maybe we should set key to 0 if key > 255?
 				if (key > 255)
 					break;
 


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.