[Scummvm-cvs-logs] SF.net SVN: scummvm: [29954] scummvm/trunk/engines/kyra/sound_towns.cpp

lordhoto at users.sourceforge.net lordhoto at users.sourceforge.net
Sun Dec 23 00:41:14 CET 2007


Revision: 29954
          http://scummvm.svn.sourceforge.net/scummvm/?rev=29954&view=rev
Author:   lordhoto
Date:     2007-12-22 15:41:14 -0800 (Sat, 22 Dec 2007)

Log Message:
-----------
Added FIXME comment.

Modified Paths:
--------------
    scummvm/trunk/engines/kyra/sound_towns.cpp

Modified: scummvm/trunk/engines/kyra/sound_towns.cpp
===================================================================
--- scummvm/trunk/engines/kyra/sound_towns.cpp	2007-12-22 23:29:15 UTC (rev 29953)
+++ scummvm/trunk/engines/kyra/sound_towns.cpp	2007-12-22 23:41:14 UTC (rev 29954)
@@ -1430,9 +1430,16 @@
 bool SoundTowns_v2::init() {
 	//_driver = new SoundTowns_v2_TwnDriver(_mixer);
 	_vm->checkCD();
-	Common::File f;
-	if (_musicEnabled && (f.exists("track1.mp3") ||
-		f.exists("track1.ogg") || f.exists("track1.flac")  || f.exists("track1.fla")))
+	// FIXME While checking for 'track1.XXX(X)' looks like
+	// a good idea, but we should definitly not be doing this
+	// here. Basically our filenaming scheme could change
+	// or we added support for other audio formats. Also
+	// this misses the posibility that we play the tracks
+	// right off CD. So we should find another way to
+	// check if we have access to CD audio.
+	if (_musicEnabled &&
+		(Common::File::exists("track1.mp3") || Common::File::exists("track1.ogg") ||
+		 Common::File::exists("track1.flac") || Common::File::exists("track1.fla")))
 			_musicEnabled = 2;
 	return true;//_driver->init();
 }


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.




More information about the Scummvm-git-logs mailing list