[Scummvm-cvs-logs] SF.net SVN: scummvm: [27087] scummvm/branches/gsoc2007-fsnode/backends/fs

david_corrales at users.sourceforge.net david_corrales at users.sourceforge.net
Tue Jun 5 00:02:36 CEST 2007


Revision: 27087
          http://scummvm.svn.sourceforge.net/scummvm/?rev=27087&view=rev
Author:   david_corrales
Date:     2007-06-04 15:02:35 -0700 (Mon, 04 Jun 2007)

Log Message:
-----------
Added stubs for the exists(), isReadable() and isWritable() methods for all architectures.

Modified Paths:
--------------
    scummvm/branches/gsoc2007-fsnode/backends/fs/abstract-fs.h
    scummvm/branches/gsoc2007-fsnode/backends/fs/amigaos4/amigaos4-fs.cpp
    scummvm/branches/gsoc2007-fsnode/backends/fs/dc/dc-fs.cpp
    scummvm/branches/gsoc2007-fsnode/backends/fs/ds/ds-fs.h
    scummvm/branches/gsoc2007-fsnode/backends/fs/gp32/gp32-fs.cpp
    scummvm/branches/gsoc2007-fsnode/backends/fs/morphos/abox-fs.cpp
    scummvm/branches/gsoc2007-fsnode/backends/fs/palmos/palmos-fs.cpp
    scummvm/branches/gsoc2007-fsnode/backends/fs/posix/posix-fs.cpp
    scummvm/branches/gsoc2007-fsnode/backends/fs/ps2/ps2-fs.cpp
    scummvm/branches/gsoc2007-fsnode/backends/fs/psp/psp_fs.cpp
    scummvm/branches/gsoc2007-fsnode/backends/fs/symbian/symbian-fs.cpp
    scummvm/branches/gsoc2007-fsnode/backends/fs/windows/windows-fs.cpp

Modified: scummvm/branches/gsoc2007-fsnode/backends/fs/abstract-fs.h
===================================================================
--- scummvm/branches/gsoc2007-fsnode/backends/fs/abstract-fs.h	2007-06-04 22:01:23 UTC (rev 27086)
+++ scummvm/branches/gsoc2007-fsnode/backends/fs/abstract-fs.h	2007-06-04 22:02:35 UTC (rev 27087)
@@ -122,14 +122,14 @@
 	virtual bool isReadable() const = 0;
 	
 	/**
-	 * Indicates whether this path can be written to or not.
+	 * Indicates whether this path is valid or not for usage.
 	 */
-	virtual bool isWritable() const = 0;
+	virtual bool isValid() const = 0;
 	
 	/**
-	 * Indicates whether this path is valid or not for usage.
+	 * Indicates whether this path can be written to or not.
 	 */
-	virtual bool isValid() const = 0;
+	virtual bool isWritable() const = 0;
 
 	/* TODO:
 	bool isFile();

Modified: scummvm/branches/gsoc2007-fsnode/backends/fs/amigaos4/amigaos4-fs.cpp
===================================================================
--- scummvm/branches/gsoc2007-fsnode/backends/fs/amigaos4/amigaos4-fs.cpp	2007-06-04 22:01:23 UTC (rev 27086)
+++ scummvm/branches/gsoc2007-fsnode/backends/fs/amigaos4/amigaos4-fs.cpp	2007-06-04 22:02:35 UTC (rev 27087)
@@ -89,11 +89,14 @@
 	 */
 	virtual ~AmigaOSFilesystemNode();
 
+	virtual bool exists() const { return true; }		//FIXME: this is just a stub
 	virtual String getDisplayName() const { return _sDisplayName; };
 	virtual String getName() const { return _sDisplayName; };
 	virtual String getPath() const { return _sPath; };
+	virtual bool isDirectory() const { return _bIsDirectory; };
+	virtual bool isReadable() const { return true; }	//FIXME: this is just a stub
 	virtual bool isValid() const { return _bIsValid; };
-	virtual bool isDirectory() const { return _bIsDirectory; };
+	virtual bool isWritable() const { return true; }	//FIXME: this is just a stub
 	
 	virtual AbstractFilesystemNode *getChild(const String &n) const;
 	virtual bool getChildren(AbstractFSList &list, ListMode mode) const;

Modified: scummvm/branches/gsoc2007-fsnode/backends/fs/dc/dc-fs.cpp
===================================================================
--- scummvm/branches/gsoc2007-fsnode/backends/fs/dc/dc-fs.cpp	2007-06-04 22:01:23 UTC (rev 27086)
+++ scummvm/branches/gsoc2007-fsnode/backends/fs/dc/dc-fs.cpp	2007-06-04 22:02:35 UTC (rev 27087)
@@ -57,11 +57,14 @@
 	 */
 	RoninCDFilesystemNode(const String &path, bool verify);
 
+	virtual bool exists() const { return true; }		//FIXME: this is just a stub
 	virtual String getDisplayName() const { return _displayName; }
 	virtual String getName() const { return _displayName; }
 	virtual String getPath() const { return _path; }
 	virtual bool isDirectory() const { return _isDirectory; }
+	virtual bool isReadable() const { return true; }	//FIXME: this is just a stub
 	virtual bool isValid() const { return _isValid; }
+	virtual bool isWritable() const { return true; }	//FIXME: this is just a stub
 
 	virtual AbstractFilesystemNode *getChild(const String &n) const;
 	virtual bool getChildren(AbstractFSList &list, ListMode mode) const;

Modified: scummvm/branches/gsoc2007-fsnode/backends/fs/ds/ds-fs.h
===================================================================
--- scummvm/branches/gsoc2007-fsnode/backends/fs/ds/ds-fs.h	2007-06-04 22:01:23 UTC (rev 27086)
+++ scummvm/branches/gsoc2007-fsnode/backends/fs/ds/ds-fs.h	2007-06-04 22:02:35 UTC (rev 27087)
@@ -77,11 +77,14 @@
 	 */
 	DSFileSystemNode(const DSFileSystemNode *node);
 	
+	virtual bool exists() const { return true; }		//FIXME: this is just a stub
 	virtual String getDisplayName() const {  return _displayName; }
 	virtual String getName() const {  return _displayName; }
 	virtual String getPath() const { return _path; }
 	virtual bool isDirectory() const { return _isDirectory; }
+	virtual bool isReadable() const { return true; }	//FIXME: this is just a stub
 	virtual bool isValid() const { return _isValid; }
+	virtual bool isWritable() const { return true; }	//FIXME: this is just a stub
 	
 	/**
 	 * Returns a copy of this node.

Modified: scummvm/branches/gsoc2007-fsnode/backends/fs/gp32/gp32-fs.cpp
===================================================================
--- scummvm/branches/gsoc2007-fsnode/backends/fs/gp32/gp32-fs.cpp	2007-06-04 22:01:23 UTC (rev 27086)
+++ scummvm/branches/gsoc2007-fsnode/backends/fs/gp32/gp32-fs.cpp	2007-06-04 22:02:35 UTC (rev 27087)
@@ -59,7 +59,9 @@
 	virtual bool isDirectory() const { return _isDirectory; }
 	// FIXME: isValid should return false if this Node can't be used!
 	// so client code can rely on the return value.
+	virtual bool isReadable() const { return true; }	//FIXME: this is just a stub
 	virtual bool isValid() const { return true; }
+	virtual bool isWritable() const { return true; }	//FIXME: this is just a stub
 
 	virtual AbstractFilesystemNode *getChild(const String &n) const;
 	virtual bool getChildren(AbstractFSList &list, ListMode mode) const;

Modified: scummvm/branches/gsoc2007-fsnode/backends/fs/morphos/abox-fs.cpp
===================================================================
--- scummvm/branches/gsoc2007-fsnode/backends/fs/morphos/abox-fs.cpp	2007-06-04 22:01:23 UTC (rev 27086)
+++ scummvm/branches/gsoc2007-fsnode/backends/fs/morphos/abox-fs.cpp	2007-06-04 22:02:35 UTC (rev 27087)
@@ -76,11 +76,14 @@
 	 */
 	~ABoxFilesystemNode();
 
+	virtual bool exists() const { return true; }		//FIXME: this is just a stub
 	virtual String getDisplayName() const { return _displayName; }
 	virtual String getName() const { return _displayName; };
 	virtual String getPath() const { return _path; }
 	virtual bool isDirectory() const { return _isDirectory; }
+	virtual bool isReadable() const { return true; }	//FIXME: this is just a stub
 	virtual bool isValid() const { return _isValid; }
+	virtual bool isWritable() const { return true; }	//FIXME: this is just a stub
 	
 	virtual AbstractFilesystemNode *getChild(const String &name) const;
 	virtual bool getChildren(AbstractFSList &list, ListMode mode) const;

Modified: scummvm/branches/gsoc2007-fsnode/backends/fs/palmos/palmos-fs.cpp
===================================================================
--- scummvm/branches/gsoc2007-fsnode/backends/fs/palmos/palmos-fs.cpp	2007-06-04 22:01:23 UTC (rev 27086)
+++ scummvm/branches/gsoc2007-fsnode/backends/fs/palmos/palmos-fs.cpp	2007-06-04 22:02:35 UTC (rev 27087)
@@ -56,11 +56,14 @@
 	 */
 	PalmOSFilesystemNode(const String &p);
 
+	virtual bool exists() const { return true; }		//FIXME: this is just a stub
 	virtual String getDisplayName() const { return _displayName; }
 	virtual String getName() const { return _displayName; }
 	virtual String getPath() const { return _path; }
 	virtual bool isDirectory() const { return _isDirectory; }
+	virtual bool isReadable() const { return true; }	//FIXME: this is just a stub
 	virtual bool isValid() const { return _isValid; }
+	virtual bool isWritable() const { return true; }	//FIXME: this is just a stub
 
 	virtual AbstractFilesystemNode *getChild(const String &n) const;
 	virtual bool getChildren(AbstractFSList &list, ListMode mode) const;

Modified: scummvm/branches/gsoc2007-fsnode/backends/fs/posix/posix-fs.cpp
===================================================================
--- scummvm/branches/gsoc2007-fsnode/backends/fs/posix/posix-fs.cpp	2007-06-04 22:01:23 UTC (rev 27086)
+++ scummvm/branches/gsoc2007-fsnode/backends/fs/posix/posix-fs.cpp	2007-06-04 22:02:35 UTC (rev 27087)
@@ -68,8 +68,8 @@
 	virtual String getPath() const { return _path; }
 	virtual bool isDirectory() const { return _isDirectory; }
 	virtual bool isReadable() const { return access(_path.c_str(), R_OK) == 0; }
+	virtual bool isValid() const { return _isValid; }
 	virtual bool isWritable() const { return access(_path.c_str(), W_OK) == 0; }
-	virtual bool isValid() const { return _isValid; }
 	
 	virtual AbstractFilesystemNode *getChild(const String &n) const;
 	virtual bool getChildren(AbstractFSList &list, ListMode mode) const;

Modified: scummvm/branches/gsoc2007-fsnode/backends/fs/ps2/ps2-fs.cpp
===================================================================
--- scummvm/branches/gsoc2007-fsnode/backends/fs/ps2/ps2-fs.cpp	2007-06-04 22:01:23 UTC (rev 27086)
+++ scummvm/branches/gsoc2007-fsnode/backends/fs/ps2/ps2-fs.cpp	2007-06-04 22:02:35 UTC (rev 27087)
@@ -62,11 +62,14 @@
 	 */
 	Ps2FilesystemNode(const Ps2FilesystemNode *node);
 
+	virtual bool exists() const { return true; }		//FIXME: this is just a stub
 	virtual String getDisplayName() const { return _displayName; }
 	virtual String getName() const { return _displayName; }
 	virtual String getPath() const { return _path; }
 	virtual bool isDirectory() const { return _isDirectory; }
+	virtual bool isReadable() const { return true; }	//FIXME: this is just a stub
 	virtual bool isValid() const { return !_isRoot; }
+	virtual bool isWritable() const { return true; }	//FIXME: this is just a stub
 
 	virtual AbstractFilesystemNode *clone() const { return new Ps2FilesystemNode(this); }
 	virtual AbstractFilesystemNode *getChild(const String &n) const;

Modified: scummvm/branches/gsoc2007-fsnode/backends/fs/psp/psp_fs.cpp
===================================================================
--- scummvm/branches/gsoc2007-fsnode/backends/fs/psp/psp_fs.cpp	2007-06-04 22:01:23 UTC (rev 27086)
+++ scummvm/branches/gsoc2007-fsnode/backends/fs/psp/psp_fs.cpp	2007-06-04 22:02:35 UTC (rev 27087)
@@ -58,11 +58,14 @@
 	 */
 	PSPFilesystemNode(const Common::String &p, bool verify);
 
+	virtual bool exists() const { return true; }		//FIXME: this is just a stub
 	virtual String getDisplayName() const { return _displayName; }
 	virtual String getName() const { return _displayName; }
 	virtual String getPath() const { return _path; }
 	virtual bool isDirectory() const { return _isDirectory; }
+	virtual bool isReadable() const { return true; }	//FIXME: this is just a stub
 	virtual bool isValid() const { return _isValid; }
+	virtual bool isWritable() const { return true; }	//FIXME: this is just a stub
 
 	virtual AbstractFilesystemNode *getChild(const String &n) const;
 	virtual bool getChildren(AbstractFSList &list, ListMode mode) const;

Modified: scummvm/branches/gsoc2007-fsnode/backends/fs/symbian/symbian-fs.cpp
===================================================================
--- scummvm/branches/gsoc2007-fsnode/backends/fs/symbian/symbian-fs.cpp	2007-06-04 22:01:23 UTC (rev 27086)
+++ scummvm/branches/gsoc2007-fsnode/backends/fs/symbian/symbian-fs.cpp	2007-06-04 22:02:35 UTC (rev 27087)
@@ -59,11 +59,14 @@
 	 */
 	SymbianFilesystemNode(const String &path);
 	
+	virtual bool exists() const { return true; }		//FIXME: this is just a stub
 	virtual String getDisplayName() const { return _displayName; }
 	virtual String getName() const { return _displayName; }
 	virtual String getPath() const { return _path; }
 	virtual bool isDirectory() const { return _isDirectory; }
+	virtual bool isReadable() const { return true; }	//FIXME: this is just a stub
 	virtual bool isValid() const { return _isValid; }
+	virtual bool isWritable() const { return true; }	//FIXME: this is just a stub
 
 	virtual AbstractFilesystemNode *getChild(const String &n) const;
 	virtual bool getChildren(AbstractFSList &list, ListMode mode) const;

Modified: scummvm/branches/gsoc2007-fsnode/backends/fs/windows/windows-fs.cpp
===================================================================
--- scummvm/branches/gsoc2007-fsnode/backends/fs/windows/windows-fs.cpp	2007-06-04 22:01:23 UTC (rev 27086)
+++ scummvm/branches/gsoc2007-fsnode/backends/fs/windows/windows-fs.cpp	2007-06-04 22:02:35 UTC (rev 27087)
@@ -78,8 +78,8 @@
 	virtual String getPath() const { return _path; }
 	virtual bool isDirectory() const { return _isDirectory; }
 	virtual bool isReadable() const { return _access(_path.c_str(), R_OK) == 0; }
+	virtual bool isValid() const { return _isValid; }
 	virtual bool isWritable() const { return _access(_path.c_str(), W_OK) == 0; }
-	virtual bool isValid() const { return _isValid; }
 
 	virtual AbstractFilesystemNode *getChild(const String &n) const;
 	virtual bool getChildren(AbstractFSList &list, ListMode mode) const;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.




More information about the Scummvm-git-logs mailing list