[Scummvm-cvs-logs] SF.net SVN: scummvm: [27425] scummvm/trunk/common/advancedDetector.cpp

fingolfin at users.sourceforge.net fingolfin at users.sourceforge.net
Fri Jun 15 19:37:29 CEST 2007


Revision: 27425
          http://scummvm.svn.sourceforge.net/scummvm/?rev=27425&view=rev
Author:   fingolfin
Date:     2007-06-15 10:37:28 -0700 (Fri, 15 Jun 2007)

Log Message:
-----------
Added a FIXME comment to the adv. detector code regarding (not) using FSNode/FSList

Modified Paths:
--------------
    scummvm/trunk/common/advancedDetector.cpp

Modified: scummvm/trunk/common/advancedDetector.cpp
===================================================================
--- scummvm/trunk/common/advancedDetector.cpp	2007-06-15 17:36:41 UTC (rev 27424)
+++ scummvm/trunk/common/advancedDetector.cpp	2007-06-15 17:37:28 UTC (rev 27425)
@@ -338,6 +338,9 @@
 		}
 	}
 
+	// TODO/FIXME: Fingolfin says: It's not good that we have two different code paths here,
+	// one using a FSList, one using File::open, as that will lead to discrepancies and subtle
+	// problems caused by those.
 	if (fslist != 0) {
 		// Get the information of the existing files
 		for (FSList::const_iterator file = fslist->begin(); file != fslist->end(); ++file) {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.




More information about the Scummvm-git-logs mailing list