[Scummvm-cvs-logs] SF.net SVN: scummvm: [28954] scummvm/trunk/common/file.cpp
lordhoto at users.sourceforge.net
lordhoto at users.sourceforge.net
Wed Sep 19 01:15:53 CEST 2007
Revision: 28954
http://scummvm.svn.sourceforge.net/scummvm/?rev=28954&view=rev
Author: lordhoto
Date: 2007-09-18 16:15:53 -0700 (Tue, 18 Sep 2007)
Log Message:
-----------
Clarified the FIXME in Common::File::exists a bit.
Modified Paths:
--------------
scummvm/trunk/common/file.cpp
Modified: scummvm/trunk/common/file.cpp
===================================================================
--- scummvm/trunk/common/file.cpp 2007-09-18 23:15:48 UTC (rev 28953)
+++ scummvm/trunk/common/file.cpp 2007-09-18 23:15:53 UTC (rev 28954)
@@ -446,9 +446,13 @@
// FIXME: since (as stated in the comment above) FilesystemNode creation
// just works for absolute paths, and we use this to tell if a file
- // exsists in any of the setup paths we can't use:
+ // exsists in any of the setup paths so we ca not use:
//return (!file.isDirectory() && file.exists());
- // if file.exsits() fails
+ //
+ // I.e.:
+ // FilesystemNode("foofile"); would fail for most (even all?)
+ // implementations where the file 'foofile' does not exist in the CWD,
+ // so we can not rely on FilesystemNode::exists, which would return false.
if (file.exists())
return !file.isDirectory();
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
More information about the Scummvm-git-logs
mailing list