[Scummvm-cvs-logs] SF.net SVN: scummvm: [31770] scummvm/trunk/engines/kyra
lordhoto at users.sourceforge.net
lordhoto at users.sourceforge.net
Tue Apr 29 16:08:09 CEST 2008
Revision: 31770
http://scummvm.svn.sourceforge.net/scummvm/?rev=31770&view=rev
Author: lordhoto
Date: 2008-04-29 07:08:08 -0700 (Tue, 29 Apr 2008)
Log Message:
-----------
- Added volume param to KyraEngine::snd_playSoundEffect (0xFF per default as in original)
- Renamed KyraEngine_v3::playSoundEffect to KyraEngine_v3::snd_playSoundEffect
- Renamed KyraEngine_v3::playMusicTrack to KyraEngine_v3::snd_playWanderScoreViaMap
- Renamed KyraEngine_v3::o3_playMusicTrack to KyraEngine_v3::o3_playWanderScoreViaMap
Modified Paths:
--------------
scummvm/trunk/engines/kyra/gui_v3.cpp
scummvm/trunk/engines/kyra/items_v3.cpp
scummvm/trunk/engines/kyra/kyra.h
scummvm/trunk/engines/kyra/kyra_v1.h
scummvm/trunk/engines/kyra/kyra_v2.cpp
scummvm/trunk/engines/kyra/kyra_v2.h
scummvm/trunk/engines/kyra/kyra_v3.cpp
scummvm/trunk/engines/kyra/kyra_v3.h
scummvm/trunk/engines/kyra/saveload_v3.cpp
scummvm/trunk/engines/kyra/scene_v3.cpp
scummvm/trunk/engines/kyra/script_v3.cpp
scummvm/trunk/engines/kyra/sequences_v3.cpp
scummvm/trunk/engines/kyra/sound.cpp
scummvm/trunk/engines/kyra/sound_v1.cpp
Modified: scummvm/trunk/engines/kyra/gui_v3.cpp
===================================================================
--- scummvm/trunk/engines/kyra/gui_v3.cpp 2008-04-29 14:05:49 UTC (rev 31769)
+++ scummvm/trunk/engines/kyra/gui_v3.cpp 2008-04-29 14:08:08 UTC (rev 31770)
@@ -443,7 +443,7 @@
_screen->hideMouse();
clearInventorySlot(slot, 0);
- playSoundEffect(0x0B, 0xC8);
+ snd_playSoundEffect(0x0B, 0xC8);
setMouseCursor(slotItem);
updateItemCommand(slotItem, (_lang == 1) ? getItemCommandStringPickUp(slotItem) : 0, 0xFF);
_itemInHand = slotItem;
@@ -458,7 +458,7 @@
if (itemInventoryMagic(_itemInHand, slot))
return 0;
- playSoundEffect(0x0B, 0xC8);
+ snd_playSoundEffect(0x0B, 0xC8);
_screen->hideMouse();
clearInventorySlot(slot, 0);
@@ -469,7 +469,7 @@
_itemInHand = slotItem;
_screen->showMouse();
} else {
- playSoundEffect(0x0C, 0xC8);
+ snd_playSoundEffect(0x0C, 0xC8);
_screen->hideMouse();
drawInventorySlot(0, _itemInHand, slot);
_screen->setMouseCursor(0, 0, getShapePtr(0));
@@ -485,7 +485,7 @@
int KyraEngine_v3::buttonMoodChange(Button *button) {
if (queryGameFlag(0x219)) {
- playSoundEffect(0x0D, 0xC8);
+ snd_playSoundEffect(0x0D, 0xC8);
return 0;
}
@@ -504,7 +504,7 @@
_screen->hideMouse();
setGameFlag(3);
- playSoundEffect(0x2E, 0xC8);
+ snd_playSoundEffect(0x2E, 0xC8);
while (_invWsaFrame != frameTable[_malcolmsMood]) {
uint32 endTime = _system->getMillis() + 2 * _tickLength;
@@ -578,7 +578,7 @@
if (_itemInHand == 27) {
_screen->hideMouse();
removeHandItem();
- playSoundEffect(0x0C, 0xC8);
+ snd_playSoundEffect(0x0C, 0xC8);
drawJestersStaff(1, 0);
updateItemCommand(27, 2, 0xFF);
setGameFlag(0x97);
@@ -586,7 +586,7 @@
} else if (_itemInHand == -1) {
if (queryGameFlag(0x97)) {
_screen->hideMouse();
- playSoundEffect(0x0B, 0xC8);
+ snd_playSoundEffect(0x0B, 0xC8);
setHandItem(27);
drawJestersStaff(0, 0);
updateItemCommand(27, 0, 0xFF);
Modified: scummvm/trunk/engines/kyra/items_v3.cpp
===================================================================
--- scummvm/trunk/engines/kyra/items_v3.cpp 2008-04-29 14:05:49 UTC (rev 31769)
+++ scummvm/trunk/engines/kyra/items_v3.cpp 2008-04-29 14:08:08 UTC (rev 31770)
@@ -190,7 +190,7 @@
if (processItemDrop(_mainCharacter.sceneId, item, x, y, unk1, unk2))
return true;
- playSoundEffect(13, 200);
+ snd_playSoundEffect(13, 200);
if (countAllItems() >= 50) {
removeTrashItems();
@@ -202,7 +202,7 @@
}
if (!_chatText)
- playSoundEffect(13, 200);
+ snd_playSoundEffect(13, 200);
return false;
}
@@ -320,7 +320,7 @@
_itemList[itemSlot].y = dstY;
_itemList[itemSlot].id = item;
_itemList[itemSlot].sceneId = _mainCharacter.sceneId;
- playSoundEffect(0x0C, 0xC8);
+ snd_playSoundEffect(0x0C, 0xC8);
addItemToAnimList(itemSlot);
} else {
uint8 *itemShape = getShapePtr(item + 248);
@@ -349,7 +349,7 @@
restoreGfxRect32x32(curX, curY-16);
if (dstX != dstY || (dstY - startY > 16)) {
- playSoundEffect(0x11, 0xC8);
+ snd_playSoundEffect(0x11, 0xC8);
speed = MAX(speed, 6);
int speedX = ((dstX - startX) << 4) / speed;
int origSpeed = speed;
@@ -389,7 +389,7 @@
_itemList[itemSlot].y = dstY;
_itemList[itemSlot].id = item;
_itemList[itemSlot].sceneId = _mainCharacter.sceneId;
- playSoundEffect(0x0C, 0xC8);
+ snd_playSoundEffect(0x0C, 0xC8);
addItemToAnimList(itemSlot);
_screen->showMouse();
}
@@ -417,7 +417,7 @@
_itemInHand = itemId;
addItemToAnimList(itemPos);
- playSoundEffect(0x0B, 0xC8);
+ snd_playSoundEffect(0x0B, 0xC8);
setMouseCursor(_itemInHand);
int str2 = 0;
@@ -445,7 +445,7 @@
deleteItemAnimEntry(itemPos);
int itemId = _itemList[itemPos].id;
_itemList[itemPos].id = 0xFFFF;
- playSoundEffect(0x0B, 0xC8);
+ snd_playSoundEffect(0x0B, 0xC8);
setMouseCursor(itemId);
int itemString = 0;
@@ -495,7 +495,7 @@
assert(animObjIndex != -1);
_screen->hideMouse();
- playSoundEffect(0x93, 0xC8);
+ snd_playSoundEffect(0x93, 0xC8);
for (int i = 109; i <= 141; ++i) {
_animObjects[animObjIndex].shapeIndex = i+248;
_animObjects[animObjIndex].needRefresh = true;
@@ -529,7 +529,7 @@
uint8 resItem = _itemMagicTable[i+2];
uint8 newItem = _itemMagicTable[i+3];
- playSoundEffect(0x0F, 0xC8);
+ snd_playSoundEffect(0x0F, 0xC8);
_itemList[itemSlot].id = (resItem == 0xFF) ? 0xFFFF : resItem;
@@ -567,7 +567,7 @@
return true;
} else if ((handItem == 6 || handItem == 7) && item == 2) {
_screen->hideMouse();
- playSoundEffect(0x93, 0xC8);
+ snd_playSoundEffect(0x93, 0xC8);
for (int i = 109; i <= 141; ++i) {
_mainCharacter.inventory[invSlot] = i;
_screen->drawShape(2, getShapePtr(invSlot+422), 0, 144, 0, 0);
@@ -590,7 +590,7 @@
uint8 resItem = _itemMagicTable[i+2];
uint8 newItem = _itemMagicTable[i+3];
- playSoundEffect(0x0F, 0xC8);
+ snd_playSoundEffect(0x0F, 0xC8);
_mainCharacter.inventory[invSlot] = (resItem == 0xFF) ? 0xFFFF : resItem;
Modified: scummvm/trunk/engines/kyra/kyra.h
===================================================================
--- scummvm/trunk/engines/kyra/kyra.h 2008-04-29 14:05:49 UTC (rev 31769)
+++ scummvm/trunk/engines/kyra/kyra.h 2008-04-29 14:08:08 UTC (rev 31770)
@@ -125,8 +125,6 @@
uint32 tickLength() const { return _tickLength; }
- virtual Movie *createWSAMovie() = 0;
-
Common::RandomSource _rnd;
// input
@@ -157,7 +155,7 @@
// sound
virtual void snd_playTheme(int file, int track);
- virtual void snd_playSoundEffect(int id);
+ virtual void snd_playSoundEffect(int id, int volume=0xFF);
virtual void snd_playWanderScoreViaMap(int command, int restart);
virtual void snd_playVoiceFile(int id) = 0;
virtual bool snd_voiceIsPlaying();
Modified: scummvm/trunk/engines/kyra/kyra_v1.h
===================================================================
--- scummvm/trunk/engines/kyra/kyra_v1.h 2008-04-29 14:05:49 UTC (rev 31769)
+++ scummvm/trunk/engines/kyra/kyra_v1.h 2008-04-29 14:08:08 UTC (rev 31770)
@@ -202,7 +202,7 @@
void readSettings();
void writeSettings();
- void snd_playSoundEffect(int track);
+ void snd_playSoundEffect(int track, int volume=0xFF);
void snd_playWanderScoreViaMap(int command, int restart);
virtual void snd_playVoiceFile(int id);
void snd_voiceWaitForFinish(bool ingame = true);
Modified: scummvm/trunk/engines/kyra/kyra_v2.cpp
===================================================================
--- scummvm/trunk/engines/kyra/kyra_v2.cpp 2008-04-29 14:05:49 UTC (rev 31769)
+++ scummvm/trunk/engines/kyra/kyra_v2.cpp 2008-04-29 14:08:08 UTC (rev 31770)
@@ -1838,8 +1838,8 @@
snd_playVoiceFile(vocFile);
}
-void KyraEngine_v2::snd_playSoundEffect(int track) {
- debugC(9, kDebugLevelMain | kDebugLevelSound, "KyraEngine_v2::snd_playSoundEffect(%d)", track);
+void KyraEngine_v2::snd_playSoundEffect(int track, int volume) {
+ debugC(9, kDebugLevelMain | kDebugLevelSound, "KyraEngine_v2::snd_playSoundEffect(%d, %d)", track, volume);
if (_flags.platform == Common::kPlatformFMTowns || _flags.platform == Common::kPlatformPC98) {
if (track == 10)
@@ -1857,7 +1857,6 @@
else if (_flags.platform == Common::kPlatformPC)
// TODO ?? Maybe there is a way to let users select whether they want
// voc, midi or adl sfx (even though it makes no sense to choose anything but voc).
- // For now this is used as a fallback only (if no voc file exists).
KyraEngine::snd_playSoundEffect(track);
}
Modified: scummvm/trunk/engines/kyra/kyra_v2.h
===================================================================
--- scummvm/trunk/engines/kyra/kyra_v2.h 2008-04-29 14:05:49 UTC (rev 31769)
+++ scummvm/trunk/engines/kyra/kyra_v2.h 2008-04-29 14:08:08 UTC (rev 31770)
@@ -842,7 +842,7 @@
void snd_loadSoundFile(int id);
void playVoice(int high, int low);
- void snd_playSoundEffect(int track);
+ void snd_playSoundEffect(int track, int volume=0xFF);
// timer
void timerFadeOutMessage(int);
Modified: scummvm/trunk/engines/kyra/kyra_v3.cpp
===================================================================
--- scummvm/trunk/engines/kyra/kyra_v3.cpp 2008-04-29 14:05:49 UTC (rev 31769)
+++ scummvm/trunk/engines/kyra/kyra_v3.cpp 2008-04-29 14:08:08 UTC (rev 31770)
@@ -383,8 +383,8 @@
_musicSoundChannel = _soundDigital->playSound(_menuAudioFile, 0xFF, Audio::Mixer::kMusicSoundType);
}
-void KyraEngine_v3::playMusicTrack(int track, int force) {
- debugC(9, kDebugLevelMain, "KyraEngine_v3::playMusicTrack(%d, %d)", track, force);
+void KyraEngine_v3::snd_playWanderScoreViaMap(int track, int force) {
+ debugC(9, kDebugLevelMain, "KyraEngine_v3::snd_playWanderScoreViaMap(%d, %d)", track, force);
// XXX byte_3C87C compare
@@ -434,7 +434,7 @@
if (_musicSoundChannel >= 0) {
if (!_soundDigital->isPlaying(_musicSoundChannel)) {
if (_lastMusicCommand != -1)
- playMusicTrack(_lastMusicCommand, 1);
+ snd_playWanderScoreViaMap(_lastMusicCommand, 1);
}
}
lock = 0;
@@ -453,8 +453,8 @@
}
}
-void KyraEngine_v3::playSoundEffect(int item, int volume) {
- debugC(9, kDebugLevelMain, "KyraEngine_v3::playSoundEffect(%d, %d)", item, volume);
+void KyraEngine_v3::snd_playSoundEffect(int item, int volume) {
+ debugC(9, kDebugLevelMain, "KyraEngine_v3::snd_playSoundEffect(%d, %d)", item, volume);
if (_sfxFileMap[item*2+0] != 0xFF) {
char filename[16];
snprintf(filename, 16, "%s.AUD", _sfxFileList[_sfxFileMap[item*2+0]]);
@@ -497,7 +497,7 @@
if (str[strSize] != '?' && str[strSize] != '!')
return;
- playSoundEffect(_curStudioSFX++, 128);
+ snd_playSoundEffect(_curStudioSFX++, 128);
if (_curStudioSFX > 291)
_curStudioSFX = 283;
@@ -1045,7 +1045,7 @@
return;
if (_unk3 == -3) {
- playSoundEffect(0x0D, 0x80);
+ snd_playSoundEffect(0x0D, 0x80);
return;
}
@@ -1619,7 +1619,7 @@
_screen->updateScreen();
delay(20, true);
- playSoundEffect(0x0E, 0xC8);
+ snd_playSoundEffect(0x0E, 0xC8);
drawOld = 0;
}
Modified: scummvm/trunk/engines/kyra/kyra_v3.h
===================================================================
--- scummvm/trunk/engines/kyra/kyra_v3.h 2008-04-29 14:05:49 UTC (rev 31769)
+++ scummvm/trunk/engines/kyra/kyra_v3.h 2008-04-29 14:08:08 UTC (rev 31770)
@@ -123,13 +123,13 @@
static const char *_soundList[];
static const int _soundListSize;
- void playMusicTrack(int track, int force);
+ void snd_playWanderScoreViaMap(int track, int force);
void stopMusicTrack();
int musicUpdate(int forceRestart);
void fadeOutMusic(int ticks);
- void playSoundEffect(int item, int volume);
+ void snd_playSoundEffect(int item, int volume);
static const uint8 _sfxFileMap[];
static const int _sfxFileMapSize;
@@ -769,7 +769,7 @@
int o3_getShapeFlag1(ScriptState *script);
int o3_setMalcolmPos(ScriptState *script);
int o3_stopMusic(ScriptState *script);
- int o3_playMusicTrack(ScriptState *script);
+ int o3_playWanderScoreViaMap(ScriptState *script);
int o3_playSoundEffect(ScriptState *script);
int o3_getScore(ScriptState *script);
int o3_blockOutRegion(ScriptState *script);
Modified: scummvm/trunk/engines/kyra/saveload_v3.cpp
===================================================================
--- scummvm/trunk/engines/kyra/saveload_v3.cpp 2008-04-29 14:05:49 UTC (rev 31769)
+++ scummvm/trunk/engines/kyra/saveload_v3.cpp 2008-04-29 14:08:08 UTC (rev 31770)
@@ -126,7 +126,7 @@
Common::InSaveFile *saveFile = openSaveForReading(fileName, header);
if (!saveFile) {
showMessageFromCCode(17, 0xB3, 0);
- playSoundEffect(0x0D, 0xC8);
+ snd_playSoundEffect(0x0D, 0xC8);
return;
}
@@ -242,9 +242,9 @@
setHandItem(_itemInHand);
if (_lastMusicCommand >= 0 && !_unkSceneScreenFlag1)
- playMusicTrack(_lastMusicCommand, 1);
+ snd_playWanderScoreViaMap(_lastMusicCommand, 1);
else if (_lastMusicCommand == -1)
- playMusicTrack(28, 1);
+ snd_playWanderScoreViaMap(28, 1);
while (!_screen->isMouseVisible())
_screen->showMouse();
Modified: scummvm/trunk/engines/kyra/scene_v3.cpp
===================================================================
--- scummvm/trunk/engines/kyra/scene_v3.cpp 2008-04-29 14:05:49 UTC (rev 31769)
+++ scummvm/trunk/engines/kyra/scene_v3.cpp 2008-04-29 14:08:08 UTC (rev 31770)
@@ -282,9 +282,9 @@
initSceneAnims(unk2);
if (_mainCharacter.sceneId == 9 && !_soundDigital->isPlaying(_musicSoundChannel))
- playMusicTrack(_sceneList[_mainCharacter.sceneId].sound, 0);
+ snd_playWanderScoreViaMap(_sceneList[_mainCharacter.sceneId].sound, 0);
if (!unk2)
- playMusicTrack(_sceneList[_mainCharacter.sceneId].sound, 0);
+ snd_playWanderScoreViaMap(_sceneList[_mainCharacter.sceneId].sound, 0);
if (unk1 && !unk2 && _mainCharacter.animFrame != 87)
moveCharacter(facing, x, y);
Modified: scummvm/trunk/engines/kyra/script_v3.cpp
===================================================================
--- scummvm/trunk/engines/kyra/script_v3.cpp 2008-04-29 14:05:49 UTC (rev 31769)
+++ scummvm/trunk/engines/kyra/script_v3.cpp 2008-04-29 14:08:08 UTC (rev 31770)
@@ -885,15 +885,15 @@
return 0;
}
-int KyraEngine_v3::o3_playMusicTrack(ScriptState *script) {
- debugC(3, kDebugLevelScriptFuncs, "KyraEngine_v3::o3_playMusicTrack(%p) (%d, %d)", (const void *)script, stackPos(0), stackPos(1));
- playMusicTrack(stackPos(0), stackPos(1));
+int KyraEngine_v3::o3_playWanderScoreViaMap(ScriptState *script) {
+ debugC(3, kDebugLevelScriptFuncs, "KyraEngine_v3::o3_playWanderScoreViaMap(%p) (%d, %d)", (const void *)script, stackPos(0), stackPos(1));
+ snd_playWanderScoreViaMap(stackPos(0), stackPos(1));
return 0;
}
int KyraEngine_v3::o3_playSoundEffect(ScriptState *script) {
debugC(3, kDebugLevelScriptFuncs, "KyraEngine_v3::o3_playSoundEffect(%p) (%d, %d)", (const void *)script, stackPos(0), stackPos(1));
- playSoundEffect(stackPos(0), stackPos(1));
+ snd_playSoundEffect(stackPos(0), stackPos(1));
return 0;
}
@@ -1552,7 +1552,7 @@
Opcode(o3_setMalcolmPos);
Opcode(o3_stopMusic);
// 0x58
- Opcode(o3_playMusicTrack);
+ Opcode(o3_playWanderScoreViaMap);
Opcode(o3_playSoundEffect);
Opcode(o3_getScore);
OpcodeUnImpl();
Modified: scummvm/trunk/engines/kyra/sequences_v3.cpp
===================================================================
--- scummvm/trunk/engines/kyra/sequences_v3.cpp 2008-04-29 14:05:49 UTC (rev 31769)
+++ scummvm/trunk/engines/kyra/sequences_v3.cpp 2008-04-29 14:08:08 UTC (rev 31770)
@@ -68,7 +68,7 @@
setupSceneAnimObject(0x0E, 9, 0, 187, -1, -1, -1, -1, 0, 0, 0, -1, animFilenames[anim]);
for (uint i = 0; i <= _badConscienceFrameTable[_badConscienceAnim]; ++i) {
if (i == 8)
- playSoundEffect(0x1B, 0xC8);
+ snd_playSoundEffect(0x1B, 0xC8);
updateSceneAnim(0x0E, i);
delay(3*_tickLength, true);
}
@@ -98,7 +98,7 @@
_badConscienceShown = false;
for (int frame = _badConscienceFrameTable[_badConscienceAnim+8]; frame >= 0; --frame) {
if (frame == 15)
- playSoundEffect(0x31, 0xC8);
+ snd_playSoundEffect(0x31, 0xC8);
updateSceneAnim(0x0E, frame);
delay(1*_tickLength, true);
}
@@ -142,7 +142,7 @@
setupSceneAnimObject(0x0F, 9, 0, 187, -1, -1, -1, -1, 0, 0, 0, -1, animFilenames[anim]);
for (uint i = 0; i <= _goodConscienceFrameTable[_goodConscienceAnim]; ++i) {
if (i == 10)
- playSoundEffect(0x7F, 0xC8);
+ snd_playSoundEffect(0x7F, 0xC8);
updateSceneAnim(0x0F, i);
delay(2*_tickLength, true);
}
@@ -172,7 +172,7 @@
_goodConscienceShown = false;
for (int frame = _goodConscienceFrameTable[_goodConscienceAnim+5]; frame >= 0; --frame) {
if (frame == 17)
- playSoundEffect(0x31, 0xC8);
+ snd_playSoundEffect(0x31, 0xC8);
updateSceneAnim(0x0F, frame);
delay(1*_tickLength, true);
}
@@ -246,7 +246,7 @@
setGameFlag(0xD1);
- playSoundEffect(0x2A, 0xC8);
+ snd_playSoundEffect(0x2A, 0xC8);
setGameFlag(0x171);
Modified: scummvm/trunk/engines/kyra/sound.cpp
===================================================================
--- scummvm/trunk/engines/kyra/sound.cpp 2008-04-29 14:05:49 UTC (rev 31769)
+++ scummvm/trunk/engines/kyra/sound.cpp 2008-04-29 14:08:08 UTC (rev 31770)
@@ -478,8 +478,8 @@
_sound->playTrack(track);
}
-void KyraEngine::snd_playSoundEffect(int track) {
- debugC(9, kDebugLevelMain | kDebugLevelSound, "KyraEngine::snd_playSoundEffect(%d)", track);
+void KyraEngine::snd_playSoundEffect(int track, int volume) {
+ debugC(9, kDebugLevelMain | kDebugLevelSound, "KyraEngine::snd_playSoundEffect(%d, %d)", track, volume);
_sound->playSoundEffect(track);
}
Modified: scummvm/trunk/engines/kyra/sound_v1.cpp
===================================================================
--- scummvm/trunk/engines/kyra/sound_v1.cpp 2008-04-29 14:05:49 UTC (rev 31769)
+++ scummvm/trunk/engines/kyra/sound_v1.cpp 2008-04-29 14:08:08 UTC (rev 31770)
@@ -28,8 +28,8 @@
namespace Kyra {
-void KyraEngine_v1::snd_playSoundEffect(int track) {
- debugC(9, kDebugLevelMain | kDebugLevelSound, "KyraEngine_v1::snd_playSoundEffect(%d)", track);
+void KyraEngine_v1::snd_playSoundEffect(int track, int volume) {
+ debugC(9, kDebugLevelMain | kDebugLevelSound, "KyraEngine_v1::snd_playSoundEffect(%d, %d)", track, volume);
if ((_flags.platform == Common::kPlatformFMTowns || _flags.platform == Common::kPlatformPC98) && track == 49) {
snd_playWanderScoreViaMap(56, 1);
return;
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
More information about the Scummvm-git-logs
mailing list