[Scummvm-cvs-logs] SF.net SVN: scummvm:[35557] scummvm/trunk

[jvprat at users.sourceforge.net]

Revision: 35557
          http://scummvm.svn.sourceforge.net/scummvm/?rev=35557&view=rev
Author:   jvprat
Date:     2008-12-26 12:15:51 +0000 (Fri, 26 Dec 2008)

Log Message:
-----------
Fix for the SliderWidget glitch when showing very small values (and potentially for other small widgets)

Modified Paths:
--------------
    scummvm/trunk/graphics/VectorRendererSpec.cpp
    scummvm/trunk/gui/ThemeEngine.cpp

Modified: scummvm/trunk/graphics/VectorRendererSpec.cpp
===================================================================
--- scummvm/trunk/graphics/VectorRendererSpec.cpp	2008-12-26 12:04:59 UTC (rev 35556)
+++ scummvm/trunk/graphics/VectorRendererSpec.cpp	2008-12-26 12:15:51 UTC (rev 35557)
@@ -426,6 +426,8 @@
 void VectorRendererSpec<PixelType, PixelFormat>::
 colorFill(PixelType *first, PixelType *last, PixelType color) {
 	register int count = (last - first);
+	if (!count)
+		return;
 	register int n = (count + 7) >> 3;
 	switch (count % 8) {
 	case 0: do {

Modified: scummvm/trunk/gui/ThemeEngine.cpp
===================================================================
--- scummvm/trunk/gui/ThemeEngine.cpp	2008-12-26 12:04:59 UTC (rev 35556)
+++ scummvm/trunk/gui/ThemeEngine.cpp	2008-12-26 12:15:51 UTC (rev 35557)
@@ -706,14 +706,7 @@
 
 	drawWidgetBackground(r, 0, kWidgetBackgroundSlider, kStateEnabled);
 
-	// TODO/FIXME: This seems to prevent displaying of
-	// slider widgets in low ranges. When disabling it
-	// the slider is shown, but it creates gfx glitches
-	// in modern theme. Modern theme uses "roundedsq"
-	// as drawing function, thus the real bug should be
-	// in VectorRenderer::drawRoundedSquare.
-	if (width > r.width() * 5 / 100)
-		queueDD(dd, r2);
+	queueDD(dd, r2);
 }
 
 void ThemeEngine::drawScrollbar(const Common::Rect &r, int sliderY, int sliderHeight, ScrollbarState scrollState, WidgetStateInfo state) {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.