[Scummvm-cvs-logs] SF.net SVN: scummvm: [32801] scummvm/trunk/engines/cine

[buddha_ at users.sourceforge.net]

Revision: 32801
          http://scummvm.svn.sourceforge.net/scummvm/?rev=32801&view=rev
Author:   buddha_
Date:     2008-06-26 08:16:15 -0700 (Thu, 26 Jun 2008)

Log Message:
-----------
Comments update.

Modified Paths:
--------------
    scummvm/trunk/engines/cine/script_fw.cpp
    scummvm/trunk/engines/cine/script_os.cpp

Modified: scummvm/trunk/engines/cine/script_fw.cpp
===================================================================
--- scummvm/trunk/engines/cine/script_fw.cpp	2008-06-26 13:50:16 UTC (rev 32800)
+++ scummvm/trunk/engines/cine/script_fw.cpp	2008-06-26 15:16:15 UTC (rev 32801)
@@ -1760,6 +1760,12 @@
 	return zoneVar;
 }
 
+/*!
+ * \todo Check whether updating the zoneQuery table is appropriate every time
+ *       this function is called because this function is called also from elsewhere
+ *       than simply o1_checkCollision (e.g. from addAni). In Operation Stealth's
+ *       disassembly this probably isn't the case, so there may be weird side-effects.
+ */
 int16 checkCollision(int16 objIdx, int16 x, int16 y, int16 numZones, int16 zoneIdx) {
 	int16 lx = objectTable[objIdx].x + x;
 	int16 ly = objectTable[objIdx].y + y;

Modified: scummvm/trunk/engines/cine/script_os.cpp
===================================================================
--- scummvm/trunk/engines/cine/script_os.cpp	2008-06-26 13:50:16 UTC (rev 32800)
+++ scummvm/trunk/engines/cine/script_os.cpp	2008-06-26 15:16:15 UTC (rev 32801)
@@ -650,8 +650,6 @@
 	return 0;
 }
 
-/*! \todo Check the current implementation for correctness
- */
 int FWScript::o2_wasZoneChecked() {
 	byte param = getNextByte();
 	_compare = (param < NUM_MAX_ZONE && zoneQuery[param]) ? 1 : 0;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.