[Scummvm-cvs-logs] SF.net SVN: scummvm:[34911] scummvm/trunk

fingolfin at users.sourceforge.net fingolfin at users.sourceforge.net
Thu Nov 6 15:27:13 CET 2008


Revision: 34911
          http://scummvm.svn.sourceforge.net/scummvm/?rev=34911&view=rev
Author:   fingolfin
Date:     2008-11-06 14:27:13 +0000 (Thu, 06 Nov 2008)

Log Message:
-----------
Got rid of OSystem::ARGBToColor and colorToARGB

Modified Paths:
--------------
    scummvm/trunk/backends/platform/PalmOS/Src/be_base.h
    scummvm/trunk/backends/platform/dc/dc.h
    scummvm/trunk/backends/platform/psp/osys_psp.cpp
    scummvm/trunk/backends/platform/psp/osys_psp.h
    scummvm/trunk/backends/platform/wii/osystem.h
    scummvm/trunk/backends/platform/wii/osystem_gfx.cpp
    scummvm/trunk/common/system.cpp
    scummvm/trunk/common/system.h

Modified: scummvm/trunk/backends/platform/PalmOS/Src/be_base.h
===================================================================
--- scummvm/trunk/backends/platform/PalmOS/Src/be_base.h	2008-11-06 14:03:38 UTC (rev 34910)
+++ scummvm/trunk/backends/platform/PalmOS/Src/be_base.h	2008-11-06 14:27:13 UTC (rev 34911)
@@ -199,9 +199,6 @@
 	virtual int16 getOverlayHeight();
 	virtual int16 getOverlayWidth();
 
-	virtual OverlayColor ARGBToColor(uint8 a, uint8 r, uint8 g, uint8 b);
-	virtual void colorToARGB(OverlayColor color, uint8 &a, uint8 &r, uint8 &g, uint8 &b);
-
 	virtual void setCursorPalette(const byte *colors, uint start, uint num);
 	virtual void disableCursorPalette(bool disable);
 

Modified: scummvm/trunk/backends/platform/dc/dc.h
===================================================================
--- scummvm/trunk/backends/platform/dc/dc.h	2008-11-06 14:03:38 UTC (rev 34910)
+++ scummvm/trunk/backends/platform/dc/dc.h	2008-11-06 14:27:13 UTC (rev 34911)
@@ -155,15 +155,8 @@
   void clearOverlay();
   void grabOverlay(int16 *buf, int pitch);
   void copyRectToOverlay(const int16 *buf, int pitch, int x, int y, int w, int h);
-  OverlayColor RGBToColor(uint8 r, uint8 g, uint8 b) { return ARGBToColor(255, r, g, b); }
+  OverlayColor RGBToColor(uint8 r, uint8 g, uint8 b) { return (0xf000|((r&0xf0)<<4)|(g&0xf0)|(b>>4); }
   void colorToRGB(OverlayColor color, uint8 &r, uint8 &g, uint8 &b) {
-    uint8 tmp; colorToARGB(color, tmp, r, g, b);
-  }
-  OverlayColor ARGBToColor(uint8 a, uint8 r, uint8 g, uint8 b) {
-    return ((a&0xf0)<<8)|((r&0xf0)<<4)|(g&0xf0)|(b>>4);
-  }
-  void colorToARGB(OverlayColor color, uint8 &a, uint8 &r, uint8 &g, uint8 &b) {
-    a = ((color>>8)&0xf0)|((color>>12)&0x0f);
     r = ((color>>4)&0xf0)|((color>>8)&0x0f);
     g = (color&0xf0)|((color>>4)&0x0f);
     b = ((color<<4)&0xf0)|(color&0x0f);

Modified: scummvm/trunk/backends/platform/psp/osys_psp.cpp
===================================================================
--- scummvm/trunk/backends/platform/psp/osys_psp.cpp	2008-11-06 14:03:38 UTC (rev 34910)
+++ scummvm/trunk/backends/platform/psp/osys_psp.cpp	2008-11-06 14:27:13 UTC (rev 34911)
@@ -363,23 +363,7 @@
 	b = (((color >> 10) & 0x1F) << 3);
 }
 
-OverlayColor OSystem_PSP::ARGBToColor(uint8 a, uint8 r, uint8 g, uint8 b) {
-	OverlayColor color = RGBToColor(r, g, b);
 
-	if (a == 255)
-		color |= 0x8000;
-
-	return color;
-}
-
-void OSystem_PSP::colorToARGB(OverlayColor color, uint8 &a, uint8 &r, uint8 &g, uint8 &b) {
-	colorToRGB(color, r, g, b);
-	if (color & 0x8000)
-		a = 255;
-	else
-		a = 0;
-}
-
 void OSystem_PSP::grabPalette(byte *colors, uint start, uint num) {
 	uint i;
 	uint16 color;

Modified: scummvm/trunk/backends/platform/psp/osys_psp.h
===================================================================
--- scummvm/trunk/backends/platform/psp/osys_psp.h	2008-11-06 14:03:38 UTC (rev 34910)
+++ scummvm/trunk/backends/platform/psp/osys_psp.h	2008-11-06 14:27:13 UTC (rev 34911)
@@ -109,8 +109,6 @@
 	virtual int16 getOverlayWidth();
 	virtual OverlayColor RGBToColor(uint8 r, uint8 g, uint8 b);
 	virtual void colorToRGB(OverlayColor color, uint8 &r, uint8 &g, uint8 &b);
-	virtual OverlayColor ARGBToColor(uint8 a, uint8 r, uint8 g, uint8 b);
-	virtual void colorToARGB(OverlayColor color, uint8 &a, uint8 &r, uint8 &g, uint8 &b);
 	virtual void grabPalette(byte *colors, uint start, uint num);
 	virtual Graphics::PixelFormat getOverlayFormat() const { return Graphics::createPixelFormat<1555>(); }
 

Modified: scummvm/trunk/backends/platform/wii/osystem.h
===================================================================
--- scummvm/trunk/backends/platform/wii/osystem.h	2008-11-06 14:03:38 UTC (rev 34910)
+++ scummvm/trunk/backends/platform/wii/osystem.h	2008-11-06 14:27:13 UTC (rev 34911)
@@ -139,9 +139,6 @@
 
 	virtual OverlayColor RGBToColor(uint8 r, uint8 g, uint8 b);
 	virtual void colorToRGB(OverlayColor color, uint8 &r, uint8 &g, uint8 &b);
-	virtual OverlayColor ARGBToColor(uint8 a, uint8 r, uint8 g, uint8 b);
-	virtual void colorToARGB(OverlayColor color, uint8 &a, uint8 &r,
-								uint8 &g, uint8 &b);
 
 	virtual bool showMouse(bool visible);
 

Modified: scummvm/trunk/backends/platform/wii/osystem_gfx.cpp
===================================================================
--- scummvm/trunk/backends/platform/wii/osystem_gfx.cpp	2008-11-06 14:03:38 UTC (rev 34910)
+++ scummvm/trunk/backends/platform/wii/osystem_gfx.cpp	2008-11-06 14:27:13 UTC (rev 34911)
@@ -454,16 +454,6 @@
 	b = (color & 0x1f) << 3;
 }
 
-OverlayColor OSystem_Wii::ARGBToColor(uint8 a, uint8 r, uint8 g, uint8 b) {
-	return RGBToColor(r, g, b);
-}
-
-void OSystem_Wii::colorToARGB(OverlayColor color, uint8 &a, uint8 &r, uint8 &g,
-								uint8 &b) {
-	a = 0xff;
-	colorToRGB(color, r, g, b);
-}
-
 bool OSystem_Wii::showMouse(bool visible) {
 	bool last = _mouseVisible;
 	_mouseVisible = visible;

Modified: scummvm/trunk/common/system.cpp
===================================================================
--- scummvm/trunk/common/system.cpp	2008-11-06 14:03:38 UTC (rev 34910)
+++ scummvm/trunk/common/system.cpp	2008-11-06 14:27:13 UTC (rev 34911)
@@ -69,15 +69,6 @@
 	Graphics::colorToRGB<Graphics::ColorMasks<565> >(color, r, g, b);
 }
 
-OverlayColor OSystem::ARGBToColor(uint8 a, uint8 r, uint8 g, uint8 b) {
-	return RGBToColor(r, g, b);
-}
-
-void OSystem::colorToARGB(OverlayColor color, uint8 &a, uint8 &r, uint8 &g, uint8 &b) {
-	colorToRGB(color, r, g, b);
-	a = 255;
-}
-
 void OSystem::displayMessageOnOSD(const char *msg) {
 	// Display the message for 1.5 seconds
 	GUI::TimedMessageDialog dialog(msg, 1500);

Modified: scummvm/trunk/common/system.h
===================================================================
--- scummvm/trunk/common/system.h	2008-11-06 14:03:38 UTC (rev 34910)
+++ scummvm/trunk/common/system.h	2008-11-06 14:27:13 UTC (rev 34911)
@@ -623,7 +623,6 @@
 	 * implementation generates a 16 bit color value, in the 565 format
 	 * (that is, 5 bits red, 6 bits green, 5 bits blue).
 	 * @see colorToRGB
-	 * @see ARGBToColor
 	 */
 	virtual OverlayColor RGBToColor(uint8 r, uint8 g, uint8 b);
 
@@ -633,32 +632,9 @@
 	 * implementation takes a 16 bit color value and assumes it to be in 565 format
 	 * (that is, 5 bits red, 6 bits green, 5 bits blue).
 	 * @see RGBToColor
-	 * @see colorToARGB
 	 */
 	virtual void colorToRGB(OverlayColor color, uint8 &r, uint8 &g, uint8 &b);
 
-	/**
-	 * Convert the given ARGB quadruplet into an OverlayColor. A OverlayColor can
-	 * be 8bit, 16bit or 32bit, depending on the target system. The default
-	 * implementation generates a 16 bit color value, in the 565 format
-	 * (that is, 5 bits red, 6 bits green, 5 bits blue).
-	 * @note The alpha component, ranges from 0 (transparent) to 255 (opaque).
-	 * @see colorToRGB
-	 * @see RGBToColor
-	 */
-	virtual OverlayColor ARGBToColor(uint8 a, uint8 r, uint8 g, uint8 b);
-
-	/**
-	 * Convert the given OverlayColor into an ARGB quadruplet. An OverlayColor can
-	 * be 8bit, 16bit or 32bit, depending on the target system. The default
-	 * implementation takes a 16 bit color value and assumes it to be in 565 format
-	 * (that is, 5 bits red, 6 bits green, 5 bits blue).
-	 * @note The alpha component, ranges from 0 (transparent) to 255 (opaque).
-	 * @see ARGBToColor
-	 * @see colorToRGB
-	 */
-	virtual void colorToARGB(OverlayColor color, uint8 &a, uint8 &r, uint8 &g, uint8 &b);
-
 	//@}
 
 


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.




More information about the Scummvm-git-logs mailing list