[Scummvm-cvs-logs] SF.net SVN: scummvm:[34946] scummvm/trunk/engines/dialogs.cpp

[eriktorbjorn at users.sourceforge.net]

Revision: 34946
          http://scummvm.svn.sourceforge.net/scummvm/?rev=34946&view=rev
Author:   eriktorbjorn
Date:     2008-11-09 09:58:59 +0000 (Sun, 09 Nov 2008)

Log Message:
-----------
Fixed warning, and what looked to me like a very minor memory leak.

Modified Paths:
--------------
    scummvm/trunk/engines/dialogs.cpp

Modified: scummvm/trunk/engines/dialogs.cpp
===================================================================
--- scummvm/trunk/engines/dialogs.cpp	2008-11-09 09:39:36 UTC (rev 34945)
+++ scummvm/trunk/engines/dialogs.cpp	2008-11-09 09:58:59 UTC (rev 34946)
@@ -169,13 +169,14 @@
 			// FIXME: at this point, the save list's selItem is -1!
 			//Common::String result(_saveDialog->getResultString());
 			Common::String result;
-			char *desc;
+			const char *desc;
 			if (result.empty()) {
 				// If the user was lazy and entered no save name, come up with a default name.
-				desc = new char[20];
-				sprintf(desc, "Save %d", slot + 1);
+				char buf[20];
+				sprintf(buf, "Save %d", slot + 1);
+				desc = buf;
 			} else {
-				desc = (char*)result.c_str();
+				desc = result.c_str();
 			}
 
 			_engine->saveGameState(slot, desc);


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.