[Scummvm-cvs-logs] SF.net SVN: scummvm:[34848] scummvm/trunk/engines/parallaction

[peres001 at users.sourceforge.net]

Revision: 34848
          http://scummvm.svn.sourceforge.net/scummvm/?rev=34848&view=rev
Author:   peres001
Date:     2008-10-26 09:15:57 +0000 (Sun, 26 Oct 2008)

Log Message:
-----------
Cleaned up disk code after recent updates to Common::SearchSet.

Modified Paths:
--------------
    scummvm/trunk/engines/parallaction/disk.h
    scummvm/trunk/engines/parallaction/disk_br.cpp

Modified: scummvm/trunk/engines/parallaction/disk.h
===================================================================
--- scummvm/trunk/engines/parallaction/disk.h	2008-10-23 19:43:37 UTC (rev 34847)
+++ scummvm/trunk/engines/parallaction/disk.h	2008-10-26 09:15:57 UTC (rev 34848)
@@ -205,13 +205,24 @@
 
 
 class Disk_br : public Disk {
+
 	Common::SeekableReadStream *openFile_internal(bool errorOnNotFound, const Common::String &name, const Common::String &ext);
+
 protected:
+	Parallaction	*_vm;
 	Common::SearchSet	_sset;
+	Common::FSDirectory *_baseDir;
 
+	uint16			_language;
+	Common::String		_currentPart;
+
 	Common::SeekableReadStream *tryOpenFile(const Common::String &name, const Common::String &ext = Common::String::emptyString);
 	Common::SeekableReadStream *openFile(const Common::String &name, const Common::String &ext = Common::String::emptyString);
 	void errorFileNotFound(const Common::String &filename);
+
+public:
+	Disk_br(Parallaction *vm);
+	virtual ~Disk_br();
 };
 
 //	for the moment DosDisk_br subclasses Disk. When Amiga support will
@@ -220,15 +231,6 @@
 class DosDisk_br : public Disk_br {
 
 protected:
-	uint16			_language;
-
-	Parallaction	*_vm;
-
-	Common::SharedPtr<Common::FSDirectory> _baseDir;
-	Common::String		_currentPart;
-
-
-protected:
 	Font *createFont(const char *name, Common::ReadStream &stream);
 	Sprites*	createSprites(Common::ReadStream &stream);
 	void loadBitmap(Common::SeekableReadStream &stream, Graphics::Surface &surf, byte *palette);
@@ -236,7 +238,6 @@
 
 public:
 	DosDisk_br(Parallaction *vm);
-	virtual ~DosDisk_br();
 
 	virtual void init();
 
@@ -263,7 +264,6 @@
 
 public:
 	DosDemoDisk_br(Parallaction *vm);
-	virtual ~DosDemoDisk_br();
 
 	virtual void init();
 
@@ -273,9 +273,6 @@
 class AmigaDisk_br : public DosDisk_br {
 
 protected:
-	Common::SharedPtr<Common::FSDirectory> _baseDir;
-	Common::String		_currentPart;
-
 	BackgroundInfo	_backgroundTemp;
 
 	Sprites*	createSprites(Common::ReadStream &stream);
@@ -283,7 +280,6 @@
 	void loadBackground(BackgroundInfo& info, Common::SeekableReadStream &stream);
 public:
 	AmigaDisk_br(Parallaction *vm);
-	virtual ~AmigaDisk_br();
 
 	virtual void init();
 

Modified: scummvm/trunk/engines/parallaction/disk_br.cpp
===================================================================
--- scummvm/trunk/engines/parallaction/disk_br.cpp	2008-10-23 19:43:37 UTC (rev 34847)
+++ scummvm/trunk/engines/parallaction/disk_br.cpp	2008-10-26 09:15:57 UTC (rev 34848)
@@ -140,23 +140,18 @@
 	_language = language;
 }
 
-DosDisk_br::DosDisk_br(Parallaction* vm) : _vm(vm) {
+DosDisk_br::DosDisk_br(Parallaction* vm) : Disk_br(vm) {
 }
 
 
 void DosDisk_br::init() {
 	// TODO: clarify whether the engine or OSystem should add the base game directory to the search manager.
 	// Right now, I am keeping an internal search set to do the job.
-	_baseDir = Common::SharedPtr<Common::FSDirectory>(new Common::FSDirectory(ConfMan.get("path")));
-	// FIXME: We use this gross hack here since we switched SearchSet to accept plain pointers
-	_sset.add("base", _baseDir.get(), 5, false);
+	_baseDir = new Common::FSDirectory(ConfMan.get("path"));
+	_sset.add("base", _baseDir, 5, false);
 }
 
 
-DosDisk_br::~DosDisk_br() {
-	_sset.clear();
-}
-
 GfxObj* DosDisk_br::loadTalk(const char *name) {
 	debugC(5, kDebugDisk, "DosDisk_br::loadTalk(%s)", name);
 
@@ -391,16 +386,11 @@
 void DosDemoDisk_br::init() {
 	// TODO: clarify whether the engine or OSystem should add the base game directory to the search manager.
 	// Right now, I am keeping an internal search set to do the job.
-	_baseDir = Common::SharedPtr<Common::FSDirectory>(new Common::FSDirectory(ConfMan.get("path"), 2));
-	// FIXME: We use this gross hack here since we switched SearchSet to accept plain pointers
-	_sset.add("base", _baseDir.get(), 5, false);
+	_baseDir = new Common::FSDirectory(ConfMan.get("path"), 2);
+	_sset.add("base", _baseDir, 5, false);
 }
 
 
-DosDemoDisk_br::~DosDemoDisk_br() {
-
-}
-
 Common::String DosDemoDisk_br::selectArchive(const Common::String& name) {
 	debugC(5, kDebugDisk, "DosDemoDisk_br::selectArchive");
 	Common::String oldPath = _currentPart;
@@ -413,9 +403,8 @@
 }
 
 void AmigaDisk_br::init() {
-	_baseDir = Common::SharedPtr<Common::FSDirectory>(new Common::FSDirectory(ConfMan.get("path")));
-	// FIXME: We use this gross hack here since we switched SearchSet to accept plain pointers
-	_sset.add("base", _baseDir.get(), 5, false);
+	_baseDir = new Common::FSDirectory(ConfMan.get("path"));
+	_sset.add("base", _baseDir, 5, false);
 
 	const Common::String subDirNames[3] = { "fonts", "backs", "common" };
 	const Common::String subDirPrefixes[3] = { "fonts", "backs", Common::String::emptyString };
@@ -423,11 +412,6 @@
 		_sset.add(subDirNames[i], _baseDir->getSubDirectory(subDirPrefixes[i], subDirNames[i], 2), 6);
 }
 
-AmigaDisk_br::~AmigaDisk_br() {
-	_sset.clear();
-}
-
-
 void AmigaDisk_br::loadBackground(BackgroundInfo& info, Common::SeekableReadStream &stream) {
 
 	byte *pal;
@@ -629,4 +613,15 @@
 }
 
 
+Disk_br::Disk_br(Parallaction *vm) : _vm(vm), _baseDir(0) {
+
+}
+
+Disk_br::~Disk_br() {
+	delete _baseDir;
+	_sset.clear();
+}
+
+
+
 } // namespace Parallaction


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.