[Scummvm-cvs-logs] SF.net SVN: scummvm:[34703] scummvm/trunk/engines/saga

[fingolfin at users.sourceforge.net]

Revision: 34703
          http://scummvm.svn.sourceforge.net/scummvm/?rev=34703&view=rev
Author:   fingolfin
Date:     2008-09-30 12:58:27 +0000 (Tue, 30 Sep 2008)

Log Message:
-----------
SAGA: Some code cleanup

Modified Paths:
--------------
    scummvm/trunk/engines/saga/music.cpp
    scummvm/trunk/engines/saga/rscfile.cpp
    scummvm/trunk/engines/saga/rscfile.h
    scummvm/trunk/engines/saga/scene.cpp
    scummvm/trunk/engines/saga/sndres.cpp

Modified: scummvm/trunk/engines/saga/music.cpp
===================================================================
--- scummvm/trunk/engines/saga/music.cpp	2008-09-30 12:38:44 UTC (rev 34702)
+++ scummvm/trunk/engines/saga/music.cpp	2008-09-30 12:58:27 UTC (rev 34703)
@@ -86,7 +86,7 @@
 
 	byte compressedHeader[10];
 
-	resourceData = _vm->_resource->getResourceData(context, resourceId);
+	resourceData = context->getResourceData(resourceId);
 	_file = context->getFile(resourceData);
 	_musicInfo = _vm->getMusicInfo();
 

Modified: scummvm/trunk/engines/saga/rscfile.cpp
===================================================================
--- scummvm/trunk/engines/saga/rscfile.cpp	2008-09-30 12:38:44 UTC (rev 34702)
+++ scummvm/trunk/engines/saga/rscfile.cpp	2008-09-30 12:58:27 UTC (rev 34703)
@@ -309,8 +309,8 @@
 		for (i = 0; i < tableSize / 8; i++) {
 			subjectResourceId = readS2.readUint32();
 			patchResourceId = readS2.readUint32();
-			subjectResourceData = getResourceData(subjectContext, subjectResourceId);
-			resourceData = getResourceData(context, patchResourceId);
+			subjectResourceData = subjectContext->getResourceData(subjectResourceId);
+			resourceData = context->getResourceData(patchResourceId);
 			subjectResourceData->patchData = new PatchData(context->file);
 			subjectResourceData->offset = resourceData->offset;
 			subjectResourceData->size = resourceData->size;
@@ -632,7 +632,7 @@
 
 	debug(8, "loadResource %d", resourceId);
 
-	resourceData = getResourceData(context, resourceId);
+	resourceData = context->getResourceData(resourceId);
 
 	file = context->getFile(resourceData);
 

Modified: scummvm/trunk/engines/saga/rscfile.h
===================================================================
--- scummvm/trunk/engines/saga/rscfile.h	2008-09-30 12:38:44 UTC (rev 34702)
+++ scummvm/trunk/engines/saga/rscfile.h	2008-09-30 12:58:27 UTC (rev 34703)
@@ -90,6 +90,18 @@
 			return file;
 		}
 	}
+
+	bool validResourceId(uint32 resourceId) const {
+		return (resourceId < count);
+	}
+
+	ResourceData *getResourceData(uint32 resourceId) const {
+		if (resourceId >= count) {
+			error("ResourceContext::getResourceData() wrong resourceId %d", resourceId);
+		}
+		return &table[resourceId];
+	}
+
 };
 
 struct MetaResource {
@@ -122,7 +134,6 @@
 	bool createContexts();
 	void clearContexts();
 	void loadResource(ResourceContext *context, uint32 resourceId, byte*&resourceBuffer, size_t &resourceSize);
-	size_t getResourceSize(ResourceContext *context, uint32 resourceId);
 	uint32 convertResourceId(uint32 resourceId);
 
 	void loadGlobalResources(int chapter, int actorsEntrance);
@@ -137,26 +148,6 @@
 		return NULL;
 	}
 
-	bool validResourceId(ResourceContext *context, uint32 resourceId) const {
-		return (resourceId < context->count);
-	}
-
-	size_t getResourceSize(ResourceContext *context, uint32 resourceId) const {
-		return getResourceData(context, resourceId)->size;
-	}
-
-	size_t getResourceOffset(ResourceContext *context, uint32 resourceId) const {
-		return getResourceData(context, resourceId)->offset;
-	}
-
-	ResourceData *getResourceData(ResourceContext *context, uint32 resourceId) const {
-		if (!validResourceId(context, resourceId)) {
-			warning("Resource::getResourceData() wrong resourceId %d", resourceId);
-			assert(0);
-		}
-		return &context->table[resourceId];
-	}
-
 private:
 	SagaEngine *_vm;
 	ResourceContext *_contexts;

Modified: scummvm/trunk/engines/saga/scene.cpp
===================================================================
--- scummvm/trunk/engines/saga/scene.cpp	2008-09-30 12:38:44 UTC (rev 34702)
+++ scummvm/trunk/engines/saga/scene.cpp	2008-09-30 12:58:27 UTC (rev 34703)
@@ -957,7 +957,7 @@
 			_resourceList[i].resourceId = readS.readUint16();
 			_resourceList[i].resourceType = readS.readUint16();
 			// demo version may contain invalid resourceId
-			_resourceList[i].invalid = !_vm->_resource->validResourceId(_sceneContext, _resourceList[i].resourceId);
+			_resourceList[i].invalid = !_sceneContext->validResourceId(_resourceList[i].resourceId);
 		}
 
 	}

Modified: scummvm/trunk/engines/saga/sndres.cpp
===================================================================
--- scummvm/trunk/engines/saga/sndres.cpp	2008-09-30 12:38:44 UTC (rev 34702)
+++ scummvm/trunk/engines/saga/sndres.cpp	2008-09-30 12:58:27 UTC (rev 34703)
@@ -205,7 +205,7 @@
 		soundResourceLength = file->size();
 	} else {
 
-		ResourceData* resourceData = _vm->_resource->getResourceData(context, resourceId);
+		ResourceData* resourceData = context->getResourceData(resourceId);
 		file = context->getFile(resourceData);
 	
 		file->seek(resourceData->offset);
@@ -373,7 +373,7 @@
 	case kSoundOGG:
 	case kSoundFLAC:
 		ResourceData *resourceData;
-		resourceData = _vm->_resource->getResourceData(context, resourceId);
+		resourceData = context->getResourceData(resourceId);
 
 		// Read compressed sfx header
 		readS.seek(1);	// Skip compression identifier byte


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.