[Scummvm-cvs-logs] SF.net SVN: scummvm:[43627] scummvm/trunk/backends/timer/default/ default-timer.cpp

[lordhoto at users.sourceforge.net]

Revision: 43627
          http://scummvm.svn.sourceforge.net/scummvm/?rev=43627&view=rev
Author:   lordhoto
Date:     2009-08-22 00:41:22 +0000 (Sat, 22 Aug 2009)

Log Message:
-----------
Add FIXME about DefaultTimerManager implementation.

Modified Paths:
--------------
    scummvm/trunk/backends/timer/default/default-timer.cpp

Modified: scummvm/trunk/backends/timer/default/default-timer.cpp
===================================================================
--- scummvm/trunk/backends/timer/default/default-timer.cpp	2009-08-22 00:27:13 UTC (rev 43626)
+++ scummvm/trunk/backends/timer/default/default-timer.cpp	2009-08-22 00:41:22 UTC (rev 43627)
@@ -124,6 +124,12 @@
 	slot->nextFireTimeMicro = interval % 1000;
 	slot->next = 0;
 
+	// FIXME: It seems we do allow the client to add one callback multiple times over here,
+	// but "removeTimerProc" will remove *all* added instances. We should either prevent
+	// multiple additions of a timer proc OR we should change removeTimerProc to only remove
+	// a specific timer proc entry.
+	// Probably we can safely just allow a single addition of a specific function once
+	// and just update our Timer documentation accordingly.
 	insertPrioQueue(_head, slot);
 
 	return true;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.