[Scummvm-cvs-logs] SF.net SVN: scummvm:[38407] scummvm/trunk/engines/sci/gfx/gfx_driver.cpp

waltervn at users.sourceforge.net waltervn at users.sourceforge.net
Tue Feb 17 15:13:42 CET 2009


Revision: 38407
          http://scummvm.svn.sourceforge.net/scummvm/?rev=38407&view=rev
Author:   waltervn
Date:     2009-02-17 14:13:42 +0000 (Tue, 17 Feb 2009)

Log Message:
-----------
SCI: Added a bounds check on the index when setting palette.

Modified Paths:
--------------
    scummvm/trunk/engines/sci/gfx/gfx_driver.cpp

Modified: scummvm/trunk/engines/sci/gfx/gfx_driver.cpp
===================================================================
--- scummvm/trunk/engines/sci/gfx/gfx_driver.cpp	2009-02-17 13:51:52 UTC (rev 38406)
+++ scummvm/trunk/engines/sci/gfx/gfx_driver.cpp	2009-02-17 14:13:42 UTC (rev 38407)
@@ -341,6 +341,12 @@
 
 static int
 scummvm_set_palette(struct _gfx_driver *drv, int index, byte red, byte green, byte blue) {
+	if (index < 0 || index > 255)
+	{
+		GFXERROR("Attempt to set invalid palette entry %d\n", index);
+		return GFX_ERROR;
+	}
+
 	byte color[] = {red, green, blue, 255};
 	g_system->setPalette(color, index, 1);
 	return GFX_OK;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.




More information about the Scummvm-git-logs mailing list