[Scummvm-cvs-logs] SF.net SVN: scummvm:[41979] scummvm/branches/gsoc2009-draci/engines/draci

[Robert Špalek]

On Tue, Jun 30, 2009 at 3:31 PM, <dkasak13 at users.sourceforge.net> wrote:

> Revision: 41979
>          http://scummvm.svn.sourceforge.net/scummvm/?rev=41979&view=rev
> Author:   dkasak13
> Date:     2009-06-30 22:31:29 +0000 (Tue, 30 Jun 2009)
>
> Log Message:
> -----------
> Added the Drawable abstract base class and made Sprite inherit from it.
>
> Modified Paths:
> --------------
>    scummvm/branches/gsoc2009-draci/engines/draci/sprite.cpp
>    scummvm/branches/gsoc2009-draci/engines/draci/sprite.h
>
> Modified: scummvm/branches/gsoc2009-draci/engines/draci/sprite.cpp
> ===================================================================
> --- scummvm/branches/gsoc2009-draci/engines/draci/sprite.cpp    2009-06-30
> 22:20:03 UTC (rev 41978)
> +++ scummvm/branches/gsoc2009-draci/engines/draci/sprite.cpp    2009-06-30
> 22:31:29 UTC (rev 41979)
> @@ -54,7 +54,11 @@
>  *  Constructor for loading sprites from a raw data buffer, one byte per
> pixel.
>  */
>  Sprite::Sprite(byte *raw_data, uint16 width, uint16 height, uint16 x,
> uint16 y,
> -                          bool columnwise) : _width(width),
> _height(height), _x(x), _y(y), _data(NULL) {
> +                          bool columnwise) : _data(NULL) {
> +        _width = width;
> +        _height = height;
> +        _x = x;
> +        _y = y;


is there a reason you change initialization _x(x) into assignment _x = x?
 at the end they have exactly the same effect, but if you already had it one
way, why are you changing it now?

-- 
Robert Špalek <rspalek at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scummvm.org/pipermail/scummvm-git-logs/attachments/20090630/a3519da0/attachment.html>