[Scummvm-cvs-logs] SF.net SVN: scummvm:[41086] scummvm/trunk/engines/gob/save

fingolfin at users.sourceforge.net fingolfin at users.sourceforge.net
Mon Jun 1 00:30:50 CEST 2009


Revision: 41086
          http://scummvm.svn.sourceforge.net/scummvm/?rev=41086&view=rev
Author:   fingolfin
Date:     2009-05-31 22:30:49 +0000 (Sun, 31 May 2009)

Log Message:
-----------
GOB: Resolve FIXMEs

Modified Paths:
--------------
    scummvm/trunk/engines/gob/save/savefile.cpp
    scummvm/trunk/engines/gob/save/saveload_v4.cpp

Modified: scummvm/trunk/engines/gob/save/savefile.cpp
===================================================================
--- scummvm/trunk/engines/gob/save/savefile.cpp	2009-05-31 22:29:50 UTC (rev 41085)
+++ scummvm/trunk/engines/gob/save/savefile.cpp	2009-05-31 22:30:49 UTC (rev 41086)
@@ -956,11 +956,7 @@
 }
 
 bool SaveWriter::canSave() const {
-	// FIXME: The logic here is the opposite from what I (Fingolfin) would expect ?!?
-	if (!_fileName.empty())
-		return false;
-	
-	return true;
+	return (!_fileName.empty());
 }
 
 Common::OutSaveFile *SaveWriter::openSave(const Common::String &fileName) {

Modified: scummvm/trunk/engines/gob/save/saveload_v4.cpp
===================================================================
--- scummvm/trunk/engines/gob/save/saveload_v4.cpp	2009-05-31 22:29:50 UTC (rev 41085)
+++ scummvm/trunk/engines/gob/save/saveload_v4.cpp	2009-05-31 22:30:49 UTC (rev 41086)
@@ -454,12 +454,8 @@
 }
 
 int32 SaveLoad_v4::ScreenPropsHandler::getSize() {
-	// FIXME: It makes no sense to call exists() here, since
-	// _file is a SlotFileIndexed file
-/*
-	if (_file->exists())
+	if (_file->exists(_slot))
 		return 256000;
-*/
 
 	return 0;
 }


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.




More information about the Scummvm-git-logs mailing list