[Scummvm-cvs-logs] SF.net SVN: scummvm:[41096] scummvm/trunk/engines/cruise/saveload.cpp

[dreammaster at users.sourceforge.net]

Revision: 41096
          http://scummvm.svn.sourceforge.net/scummvm/?rev=41096&view=rev
Author:   dreammaster
Date:     2009-06-01 08:46:39 +0000 (Mon, 01 Jun 2009)

Log Message:
-----------
Removed the remaining two FIXME's - my analysis of the data indicates no issues with structure packing, and all multi-byte data accesses are wrapped using loadShort/saveShort, which is endian safe

Modified Paths:
--------------
    scummvm/trunk/engines/cruise/saveload.cpp

Modified: scummvm/trunk/engines/cruise/saveload.cpp
===================================================================
--- scummvm/trunk/engines/cruise/saveload.cpp	2009-06-01 08:00:58 UTC (rev 41095)
+++ scummvm/trunk/engines/cruise/saveload.cpp	2009-06-01 08:46:39 UTC (rev 41096)
@@ -258,7 +258,6 @@
 			// save BSS
 			s.syncAsSint16LE(ovlData->sizeOfData4);
 			if (ovlData->sizeOfData4)
-				// FIXME: Endian and structure packing problems for this data pointer
 				s.syncBytes(ovlData->data4Ptr, ovlData->sizeOfData4);
 
 			// save variables
@@ -344,8 +343,6 @@
 		s.syncAsSint16LE(ptr->varA);
 
 		if (ptr->varA) {
-			// FIXME: This code is not endian safe, and breaks if struct
-			// packing changes. Read/write the members one by one instead.
 			if (s.isLoading())
 				ptr->var6 = (byte *)mallocAndZero(ptr->varA);
 			s.syncBytes(ptr->var6, ptr->varA);


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.