[Scummvm-cvs-logs] SF.net SVN: scummvm:[41617] scummvm/branches/gsoc2009-draci/engines/draci

[dkasak13 at users.sourceforge.net]

Revision: 41617
          http://scummvm.svn.sourceforge.net/scummvm/?rev=41617&view=rev
Author:   dkasak13
Date:     2009-06-17 23:11:24 +0000 (Wed, 17 Jun 2009)

Log Message:
-----------
Added kNumColours constant and replaced magic numbers with it.

Modified Paths:
--------------
    scummvm/branches/gsoc2009-draci/engines/draci/draci.cpp
    scummvm/branches/gsoc2009-draci/engines/draci/screen.cpp
    scummvm/branches/gsoc2009-draci/engines/draci/screen.h

Modified: scummvm/branches/gsoc2009-draci/engines/draci/draci.cpp
===================================================================
--- scummvm/branches/gsoc2009-draci/engines/draci/draci.cpp	2009-06-17 22:37:39 UTC (rev 41616)
+++ scummvm/branches/gsoc2009-draci/engines/draci/draci.cpp	2009-06-17 23:11:24 UTC (rev 41617)
@@ -131,7 +131,7 @@
 		return 0;
 	}	
 
-	_screen->setPalette(f->_data, 0, 256);
+	_screen->setPalette(f->_data, 0, kNumColours);
 	
 	// Fill screen with white
 	_screen->fillScreen(255);
@@ -187,7 +187,7 @@
 	}	
 
 	Sprite sp(f->_data, f->_length, 0, 0, true);
-	CursorMan.pushCursorPalette(_screen->getPalette(), 0, 256);
+	CursorMan.pushCursorPalette(_screen->getPalette(), 0, kNumColours);
 	CursorMan.pushCursor(sp._data, sp._width, sp._height, sp._width / 2, sp._height / 2);
 	CursorMan.showMouse(true);
 

Modified: scummvm/branches/gsoc2009-draci/engines/draci/screen.cpp
===================================================================
--- scummvm/branches/gsoc2009-draci/engines/draci/screen.cpp	2009-06-17 22:37:39 UTC (rev 41616)
+++ scummvm/branches/gsoc2009-draci/engines/draci/screen.cpp	2009-06-17 23:11:24 UTC (rev 41617)
@@ -30,11 +30,13 @@
 
 namespace Draci {
 
+const uint16 kNumColours = 256;
+
 Screen::Screen(DraciEngine *vm) : _vm(vm) {
 	_surface = new Graphics::Surface();
 	_surface->create(_vm->_screenWidth, _vm->_screenHeight, 1);
 	this->clearScreen();
-	_palette = new byte[4 * 256];
+	_palette = new byte[4 * kNumColours];
 	setPaletteEmpty();
 }
 
@@ -45,7 +47,7 @@
 }
 
 void Screen::setPaletteEmpty(unsigned int numEntries) {
-	for (unsigned int i = 0; i < numEntries * 4; ++i) {
+	for (unsigned int i = 0; i < 4 * numEntries; ++i) {
 		_palette[i] = 0;
 	}
 
@@ -55,7 +57,7 @@
 
 void Screen::setPalette(byte *data, uint16 start, uint16 num) {
 
-	Common::MemoryReadStream pal(data, 256 * 3);
+	Common::MemoryReadStream pal(data, 3 * kNumColours);
 	pal.seek(start * 4);
 
 	// Copy the palette	
@@ -68,7 +70,7 @@
 
 	// TODO: Investigate why this is needed
 	// Shift the palette one bit to the left to make it brighter
-	for (unsigned int i = 0; i < 4 * 256; ++i) {
+	for (unsigned int i = 0; i < 4 * kNumColours; ++i) {
 		_palette[i] <<= 2;
 	}
 

Modified: scummvm/branches/gsoc2009-draci/engines/draci/screen.h
===================================================================
--- scummvm/branches/gsoc2009-draci/engines/draci/screen.h	2009-06-17 22:37:39 UTC (rev 41616)
+++ scummvm/branches/gsoc2009-draci/engines/draci/screen.h	2009-06-17 23:11:24 UTC (rev 41617)
@@ -32,6 +32,8 @@
 
 namespace Draci {
 
+extern const uint16 kNumColours;
+
 class DraciEngine;
 
 class Screen {
@@ -40,7 +42,7 @@
 	Screen(DraciEngine *vm);
 	~Screen();
 
-	void setPaletteEmpty(unsigned int numEntries = 256);
+	void setPaletteEmpty(unsigned int numEntries = kNumColours);
 	void setPalette(byte *data, uint16 start, uint16 num);
 	byte *getPalette() const;
 	void copyToScreen() const;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.