[Scummvm-cvs-logs] SF.net SVN: scummvm:[39183] scummvm/branches/branch-0-13-0/engines/agos/ saveload.cpp

Kirben at users.sourceforge.net Kirben at users.sourceforge.net
Sat Mar 7 14:32:23 CET 2009


Revision: 39183
          http://scummvm.svn.sourceforge.net/scummvm/?rev=39183&view=rev
Author:   Kirben
Date:     2009-03-07 13:32:23 +0000 (Sat, 07 Mar 2009)

Log Message:
-----------
Fix buffer overflow in matchSaveGame().

Modified Paths:
--------------
    scummvm/branches/branch-0-13-0/engines/agos/saveload.cpp

Modified: scummvm/branches/branch-0-13-0/engines/agos/saveload.cpp
===================================================================
--- scummvm/branches/branch-0-13-0/engines/agos/saveload.cpp	2009-03-07 13:29:11 UTC (rev 39182)
+++ scummvm/branches/branch-0-13-0/engines/agos/saveload.cpp	2009-03-07 13:32:23 UTC (rev 39183)
@@ -256,9 +256,10 @@
 
 int16 AGOSEngine::matchSaveGame(const char *name, uint16 max) {
 	Common::InSaveFile *in;
-	char dst[8];
+	char dst[10];
 	uint16 slot;
 
+	memset(dst, 0, sizeof(dst));
 	for (slot = 0; slot < max; slot++) {
 		if ((in = _saveFileMan->openForLoading(genSaveName(slot)))) {
 			in->read(dst, 8);


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.




More information about the Scummvm-git-logs mailing list