[Scummvm-cvs-logs] SF.net SVN: scummvm:[40307] scummvm/trunk/engines/tinsel/detection.cpp

[fingolfin at users.sourceforge.net]

Revision: 40307
          http://scummvm.svn.sourceforge.net/scummvm/?rev=40307&view=rev
Author:   fingolfin
Date:     2009-05-04 15:05:25 +0000 (Mon, 04 May 2009)

Log Message:
-----------
TINSEL: Added FIXME comment about a valgrind warning (calling strcpy on overlapping strings is unsafe)

Modified Paths:
--------------
    scummvm/trunk/engines/tinsel/detection.cpp

Modified: scummvm/trunk/engines/tinsel/detection.cpp
===================================================================
--- scummvm/trunk/engines/tinsel/detection.cpp	2009-05-04 15:05:11 UTC (rev 40306)
+++ scummvm/trunk/engines/tinsel/detection.cpp	2009-05-04 15:05:25 UTC (rev 40307)
@@ -604,7 +604,7 @@
 			char tempFilename[50];
 			strcpy(tempFilename, fileDesc->fileName);
 			char *pOne = strchr(tempFilename, '1');
-			if (pOne) strcpy(pOne, pOne + 1);
+			if (pOne) strcpy(pOne, pOne + 1);	// FIXME: Valgrind complains about this
 
 			Common::String fname(tempFilename);
 			if (allFiles.contains(fname) && !filesSizeMD5.contains(fname)) {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.