[Scummvm-cvs-logs] SF.net SVN: scummvm:[40510] scummvm/trunk/engines/cruise/dataLoader.cpp

[eriktorbjorn at users.sourceforge.net]

Revision: 40510
          http://scummvm.svn.sourceforge.net/scummvm/?rev=40510&view=rev
Author:   eriktorbjorn
Date:     2009-05-12 20:13:42 +0000 (Tue, 12 May 2009)

Log Message:
-----------
Surely this function is supposed to return -2 when the memory allocation
*fails*, not when it succeeds...?

Modified Paths:
--------------
    scummvm/trunk/engines/cruise/dataLoader.cpp

Modified: scummvm/trunk/engines/cruise/dataLoader.cpp
===================================================================
--- scummvm/trunk/engines/cruise/dataLoader.cpp	2009-05-12 20:12:49 UTC (rev 40509)
+++ scummvm/trunk/engines/cruise/dataLoader.cpp	2009-05-12 20:13:42 UTC (rev 40510)
@@ -194,7 +194,7 @@
 
 	filesDatabase[entryNumber].subData.ptr = (uint8 *) mallocAndZero(size + div);
 
-	if (filesDatabase[entryNumber].subData.ptr) {
+	if (!filesDatabase[entryNumber].subData.ptr) {
 		return (-2);
 	}
 


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.