[Scummvm-cvs-logs] SF.net SVN: scummvm:[40580] scummvm/trunk/engines/sci/engine/savegame.cpp

[fingolfin at users.sourceforge.net]

Revision: 40580
          http://scummvm.svn.sourceforge.net/scummvm/?rev=40580&view=rev
Author:   fingolfin
Date:     2009-05-14 23:10:22 +0000 (Thu, 14 May 2009)

Log Message:
-----------
SCI: Added a paranoia check to find_unique_script_block which causes us to bail out if we are about to get stuck in an endless loop

Modified Paths:
--------------
    scummvm/trunk/engines/sci/engine/savegame.cpp

Modified: scummvm/trunk/engines/sci/engine/savegame.cpp
===================================================================
--- scummvm/trunk/engines/sci/engine/savegame.cpp	2009-05-14 23:10:04 UTC (rev 40579)
+++ scummvm/trunk/engines/sci/engine/savegame.cpp	2009-05-14 23:10:22 UTC (rev 40580)
@@ -518,12 +518,12 @@
 
 	do {
 		int seeker_type = READ_LE_UINT16(buf);
-		int seeker_size;
 
 		if (seeker_type == 0) break;
 		if (seeker_type == type) return buf;
 
-		seeker_size = READ_LE_UINT16(buf + 2);
+		int seeker_size = READ_LE_UINT16(buf + 2);
+		assert(seeker_size > 0);
 		buf += seeker_size;
 	} while(1);
 


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.